From f0923d0251cccfdc53601581e9d438c570ea1d0b Mon Sep 17 00:00:00 2001 From: Ben Noordhuis Date: Mon, 16 Dec 2019 15:19:08 +0100 Subject: [PATCH] build: remove -pedantic from compiler flags MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit This flag emits warnings with some versions of gcc that we don't care about (libuv targets POSIX conformance, not strict ISO C conformance) and it's arguably not that useful as libuv is compiled in -std=gnu89 mode. Fixes: https://github.com/libuv/libuv/pull/2567 PR-URL: https://github.com/libuv/libuv/pull/2570 Reviewed-By: Colin Ihrig Reviewed-By: Richard Lau Reviewed-By: Saúl Ibarra Corretgé --- configure.ac | 3 --- uv.gyp | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/configure.ac b/configure.ac index 6ea6b6a06cd..0c97dad781b 100644 --- a/configure.ac +++ b/configure.ac @@ -24,9 +24,6 @@ AC_ENABLE_SHARED AC_ENABLE_STATIC AC_PROG_CC AM_PROG_CC_C_O -AS_IF([AS_CASE([$host_os],[openedition*], [false], [true])], [ - CC_CHECK_CFLAGS_APPEND([-pedantic]) -]) CC_FLAG_VISIBILITY #[-fvisibility=hidden] CC_CHECK_CFLAGS_APPEND([-g]) CC_CHECK_CFLAGS_APPEND([-std=gnu89]) diff --git a/uv.gyp b/uv.gyp index c4564c04086..116b7537195 100644 --- a/uv.gyp +++ b/uv.gyp @@ -93,7 +93,7 @@ '-Wno-unused-parameter', '-Wstrict-prototypes', ], - 'OTHER_CFLAGS': [ '-g', '--std=gnu89', '-pedantic' ], + 'OTHER_CFLAGS': [ '-g', '--std=gnu89' ], }, 'conditions': [ [ 'OS=="win"', { @@ -217,7 +217,6 @@ '-fvisibility=hidden', '-g', '--std=gnu89', - '-pedantic', '-Wall', '-Wextra', '-Wno-unused-parameter',