Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backpacks spec #1

Open
ms5984 opened this issue Oct 26, 2022 · 6 comments
Open

Backpacks spec #1

ms5984 opened this issue Oct 26, 2022 · 6 comments
Labels
documentation Improvements or additions to documentation

Comments

@ms5984
Copy link
Member

ms5984 commented Oct 26, 2022

Backpacks

  • Integrate with Accessories plugin (assign items the Backpack accessory category, if possible)
    • can have an associated cosmetic (per backpack)
  • open by
    • right-clicking a backpack item while it's in your inventory
    • holding the backpack item in your main hand and right-clicking
  • toggleable item collection
    • Backpacks can pickup items automatically
    • Some backpacks (not all) will have this feature
    • To activate this feature the backpack must be active in an accessory slot (fill left to right, i guess)
  • API
    • create(): Make a new empty backpack
    • loadFromItem(ItemStack): Read data from an item to reconstruct its contents
  • Commands
    • /backpacks give [player] (defaults to self)
  • Limits
    • cannot be placed inside another backpack
  • Features
    • Players can add rows to their backpacks
    • Toggle item collecting feature (if available) via gui
    • Pagination

Out of scope

  • can edit the backpack item
    • display name
    • material
    • lore
    • custom model data
@ms5984
Copy link
Member Author

ms5984 commented Oct 26, 2022

@TadiklCZE I think I can make the right decisions, but if you have any feedback about the questions i raised just let me know

@ms5984 ms5984 changed the title Backpacks Backpacks spec Oct 26, 2022
@ms5984
Copy link
Member Author

ms5984 commented Oct 27, 2022

Updated description

  • specify editable attributes of backpack items
  • add inventory title to styling requirements

@ms5984
Copy link
Member Author

ms5984 commented Oct 27, 2022

Updated item collection spec

  • describe
  • some backpacks, not all
  • backpack must be in accessory slot

@ms5984
Copy link
Member Author

ms5984 commented Oct 27, 2022

@TadiklCZE

what if we make something like a robot upgrade or skill
that collects the item from the ground to the backpack instead
so if you got the robot activated and the backpack in the slot
it will put the items there

@ms5984
Copy link
Member Author

ms5984 commented Nov 3, 2022

Updated spec

  • No nesting of backpacks

@ms5984
Copy link
Member Author

ms5984 commented Nov 7, 2022

Updated spec

  • reflect changes in approach
  • mark item styling as out-of-scope for now (Backpacks only reads/uses PDC)

@ms5984 ms5984 removed the help wanted Extra attention is needed label Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

1 participant