Teams suffix/prefix limits is based on server version

[f4n74z14]

Describe the bug
If you have packet-based plugins for teams, PacketEvents do not support them (extended limits and etc.) because determines version from the server rather than the client.

Software brand
PaperSpigot 1.8.8

Plugins
ViaVersion, GrimAC (2.3.67), TAB

How To Reproduce
Steps to reproduce the behavior:

1. Set prefix more than 16 chars in TAB on 1.8.8 server
2. Try decode PlayServerTeam
3. The error will appear

Expected behavior
PacketEvents determines version from the client rather than the server.

[AoElite]

@f4n74z14 You need to send the error

[f4n74z14]

@f4n74z14 You need to send the error

https://pastebin.com/ZZVpkiKn

[SamB440]

How does via handle this?

[f4n74z14]

I haven't looked into Via's code, but logically I don't see why the server version is used when writing/reading a client-only packet.

[SamB440]

Server version is used in all packets because via expects packets sent from the server to be of that version, likewise packetevents does, otherwise you get errors due to differing client and server versions.

[f4n74z14]

You are right! Perhaps this could be done by combining the client and server versions, for example: the packet structure would be server based and the limits would be client based. (I looked how it is done in BungeeCord, there the limits are the same for all - Short.MAX_VALUE).

[f4n74z14]

It's also an issue for team name limit.