Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing Wrapper #415

Open
SkyLicks opened this issue Jun 2, 2022 · 3 comments · May be fixed by #423
Open

Missing Wrapper #415

SkyLicks opened this issue Jun 2, 2022 · 3 comments · May be fixed by #423
Labels
enhancement New feature or request

Comments

@SkyLicks
Copy link

SkyLicks commented Jun 2, 2022

Is your feature request related to a problem? Please describe.
It appears that PacketEvents is missing a wrapper for https://wiki.vg/Protocol#Effect.

Describe the solution you'd like
I hope to get a wrapper for this implemented

Describe alternatives you've considered to solve your solution without
us adding this as a feature?

N/A

Additional context
N/A

@SkyLicks SkyLicks added the enhancement New feature or request label Jun 2, 2022
@NoJokeFNA
Copy link
Contributor

If you really need it right now, there you go:
https://github.com/retrooper/packetevents/actions/runs/2353263171
#370

I just closed it because I want to provide some abstraction cross versions and it takes some time. But if you really need it you can either use this version from the Actions or you implement it on your own and build the jar.

@NoJokeFNA
Copy link
Contributor

#423 @SkyLicks

@NoJokeFNA
Copy link
Contributor

NoJokeFNA commented Jun 10, 2022

Can be closed

@NoJokeFNA NoJokeFNA linked a pull request Jul 15, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants