Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Player was null on declare commands packet #1036

Open
axeldupuy opened this issue Oct 22, 2024 · 2 comments · May be fixed by #1096
Open

Player was null on declare commands packet #1036

axeldupuy opened this issue Oct 22, 2024 · 2 comments · May be fixed by #1096
Labels
bug Something isn't working

Comments

@axeldupuy
Copy link

Describe the bug
DeclareCommands packet is sometimes null

Software brand
Pufferfish 1.17.1

Plugins
Pl-Hide-Pro

How To Reproduce

  1. Join the server.
  2. Error: [Pl-Hide-Pro] Player was null on declare commands packet

Screenshots

Screenshot_1
Screenshot_2
Screenshot_3

@axeldupuy axeldupuy added the bug Something isn't working label Oct 22, 2024
@retrooper
Copy link
Owner

Saying that the "DeclareCommands" is null sounds confusing. However, it is possible that the Bukkit player object is null, as PacketEvents has not fetched it, considering the fact that it's instantiated later (compared to when the connection is established). My response would be, either contact me so we can go through specifics, or they can attempt to adapt their code to be less dependent on the Bukkit player in that connection stage. Perhaps, they could also try fetching it using the Bukkit API and the User object's UUID.

@smscentras
Copy link

smscentras commented Nov 18, 2024

Same problem there, mass flood in console!

[06:01:13] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:20] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:20] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:27] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:33] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:39] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:46] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:01:53] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:00] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:06] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:13] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:20] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:26] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet
[06:02:33] [Netty Server IO #3/WARN]: [Pl-Hide-Pro] Player was null on declare commands packet

@booky10 booky10 linked a pull request Dec 22, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants