Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Account for HTML tags order and overlapping #12

Open
retifrav opened this issue May 17, 2022 · 0 comments
Open

Account for HTML tags order and overlapping #12

retifrav opened this issue May 17, 2022 · 0 comments
Assignees
Labels
feature things to do, feature request
Milestone

Comments

@retifrav
Copy link
Owner

Current implementation of subtitles validation (#10) doesn't account for order and overlapping of HTML tags, so for example this title won't fail validation:

2
00:00:34,840 --> 00:00:36,840
That is clearly </u>wrong<u>,
even though open/close tags count is fine.

neither will this one:

3
00:00:40,760 --> 00:00:43,760
Tags <font color"green">are <b>incorrectly</font> overlapping</b>,
but still the count of open/close is fine, so no problem is raised.
@retifrav retifrav added the feature things to do, feature request label May 17, 2022
@retifrav retifrav self-assigned this May 17, 2022
@retifrav retifrav added this to the v0.7.0 milestone May 17, 2022
@retifrav retifrav modified the milestones: v0.7.0, v0.8.0 Sep 11, 2023
@retifrav retifrav modified the milestones: v0.8.0, v.0.9.0 Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature things to do, feature request
Projects
None yet
Development

No branches or pull requests

1 participant