Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-d tasks only tracks cpu0 #14

Open
reticulatedpines opened this issue Oct 31, 2023 · 0 comments
Open

-d tasks only tracks cpu0 #14

reticulatedpines opened this issue Oct 31, 2023 · 0 comments

Comments

@reticulatedpines
Copy link
Owner

Old code assumes only one cpu, eos_tasks_log_exec() logs task switches via eos_state->model->current_task_addr, which is only for cpu0.

Really this current_task_addr should be part of the cpu, not the model, or we need multiple current_task_addr fields for the model.

print_task_switch() should output which cpu it's logging (adding this but never seeing cpu1 is how I found this bug).

eos_tasks_log_exec() should be moved to the instruction monitoring plugin, qemu 4 doesn't provide accurate per instruction logging anymore so we may be missing events - and the plugin is faster. In practice task switch logging seems to work okay, maybe because large jumps tend to generate new TBs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant