Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ML ASSERT() doesn't assert, rename #130

Open
reticulatedpines opened this issue Jan 28, 2024 · 0 comments
Open

ML ASSERT() doesn't assert, rename #130

reticulatedpines opened this issue Jan 28, 2024 · 0 comments

Comments

@reticulatedpines
Copy link
Owner

We have ASSERT(), but it isn't an assert, it's just a check-and-warn. And it's always included, there's no debug / release split.

This is confusing for devs, especially new devs, who may expect that ASSERTS a) only exist in debug builds b) when included, prevent later code from executing if the assert fails.

WARN() may be a more appropriate name. Note there is also a DryOS assert(), which is a function pointer so might not assert, but in practice always does. We also, optionally, replace this function pointer with our own (that does more verbose logging then transfers to DryOS original debug_assert().

@reticulatedpines reticulatedpines changed the title ML ASSESRT() doesn't assert, rename ML ASSERT() doesn't assert, rename Jan 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant