Build binaries with relro/pie/bind_now #281
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idorax
force-pushed
the
dev.huanli.20230117.255
branch
2 times, most recently
from
606f3e5 to
03b39d2
Compare
idorax
force-pushed
the
dev.huanli.20230117.255
branch
2 times, most recently
from
2ab526c to
02c259f
Compare
idorax
force-pushed
the
dev.huanli.20230117.255
branch
from
02c259f to
100eb06
Compare
|
Looks good to me, as long as annocheck doesn't find any issues when this is built. Thanks! Note that the second |
Signed-off-by: Vector Li <[email protected]>
idorax
force-pushed
the
dev.huanli.20230117.255
branch
from
100eb06 to
6ea6862
Compare
Removed. @comps, thanks for your review! |
|
Looks the priority of the related issue is very low, so just close this PR to avoid unnecessary efforts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note that package 'annobin-plugin-gcc' should be installed on the system to build the binaries.
Fixes: #255