restraint-client barfs raw data and disconnects

[wizardofoz123]

Sometimes when LWD (WARN Score: 0 . /10_localwatchdog) is hit, restraint-client barfs raw input:

[gigabyte-r120-18.khw] {"headers":{"Host":"localhost:33657","Content-Range":"bytes 1835008-1966079\/3359984","Content-Type":"text\/plain","Accept-Encoding":"gzip, deflate","Connection":"Keep-Alive","Content-Length":"131072","rstrnt-path":"\/recipes\/9781759\/tasks\/17\/logs\/journalctl","rstrnt-method":"PUT","body-length":131072},"body":"bmcuYm9zLnJlZGhhdC

<...>more raw data

1hciAyOSAxNzclient_loop: send disconnect: Broken pipe

Afterwards the system reboots and after a few connection retries, execution of tests continues.

[wizardofoz123]

Found out a reproducer by accident:

1. clone CKI (UPT pipeline) job
2. start running tests in restraint standalone (e.g. sleep 3600, see example xml below)
3. run rstrnt-adjust-watchdog -s http://localhost:${{PORT}}/recipes/{recipe_id}/watchdog 1 with correct PORT and recipe_id substituted; PORT is the port of restraintd runner instance (not Beaker restraint)
4. the task will complete with WARN
5. restraint barfs raw data

Example restraint xml to used:

<?xml version="1.0" encoding="utf-8"?>
            <job>
             <recipeSet>
              <recipe id="1234" job_id="5678">
                <task name="/distribution/command" role="STANDALONE">
                 <fetch url="https://github.com/beaker-project/beaker-core-tasks/archive/master.tar.gz#command"/>
                 <params>
                  <param name="TESTARGS" value="sleep 3600"/>
                 </params>
                </task>
               </recipe>
             </recipeSet>
            </job>

[idorax]

2. start running tests in restraint standalone (e.g. sleep 3600, see example xml below)

Hi @wizardofoz123, is there a constraint command line to reproduce this problem? I'll have a try to reproduce it then fix it, thanks!

3. run rstrnt-adjust-watchdog -s http://localhost:${{PORT}}/recipes/{recipe_id}/watchdog 1 with correct PORT and recipe_id substituted; PORT is the port of restraintd runner instance (not Beaker restraint)

It should be rstrnt-adjust-watchdog -s http://localhost:${PORT}/recipes/${recipe_id}/watchdog 1, right?