Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFE] flush & upload taskout.log before reboot #185

Open
AloisMahdal opened this issue Feb 17, 2021 · 0 comments
Open

[RFE] flush & upload taskout.log before reboot #185

AloisMahdal opened this issue Feb 17, 2021 · 0 comments

Comments

@AloisMahdal
Copy link

Because runtest.sh output is cached and uploaded only every 15 seconds, when I have a task that initiates reboot, anything potentially useful that I might write to console (like "rebooting.." messafe) is likely to be kept in the cache and only shown to user (observer of the job in Beaker WUI) only after the reboot.

For example, if I have runtest.sh like this:

case $REBOOTCOUNT in
    0)
        echo >&2 "$(date -Isec) REBOOTCOUNT too low, rebooting to increase it..."
        rstrnt-reboot
        ;;
    *)
        "$(date -Isec) REBOOTCOUNT is OK now, going on..."
        ;;
esac

When such task runs, depending on exact timing the "too low" message is likely to not be shown until after the reboot, when it will appear along with the rest of the log.

The scenario when this makes most sense is when the reboot takes non-trivial amount of time, and at the same time someone would like to keep an eye on the status of the test.

During the rebooting period, not seeing the "rebooting" message is counter-intuitive and it might seem like eg. the code got stuck earlier.

One instance of similar test is in-place major RHEL upgrade test, where the "reboot" is where we go to upgrade initramfs and perform the whole transaction --- this can easily take an hour.

The idea is that restraint could make another flush & upload outside of the 15-sec heartbeat:

  • either when a specific command (added by this RFE) is called (this option would run the risk of being "abused"),
  • or as part of rstrnt-reboot,
  • or when the daemon is shutting down.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants