Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More descriptive error messages #149

Open
mkenigs opened this issue Aug 18, 2020 · 3 comments
Open

More descriptive error messages #149

mkenigs opened this issue Aug 18, 2020 · 3 comments
Labels

Comments

@mkenigs
Copy link

mkenigs commented Aug 18, 2020

I was trying to run a task on a host without make installed, and even with -vvv, there's no indication anything other than the task itself failed. Would be nice if command not found or something else more descriptive was output

[ip        ] ** Fetching task: 1 [/var/lib/restraint/tests/github.com/beaker-project/beaker-core-tasks/archive/master.zip/command]
[ip        ] ** Extracting command/
[ip        ] ** Extracting command/Makefile
[ip        ] ** Extracting command/PURPOSE
[ip        ] ** Extracting command/runtest.sh
[ip        ] ** Fetch Summary: Match 4, Nonmatch 149
[ip        ] ** Preparing metadata
[ip        ] use_pty:FALSE make testinfo.desc
[ip        ] ** Completed Task : 1
One or more tasks failed [restraint-error-quark, 10]

@danrodrig
Copy link
Contributor

This is an issue affecting restraint in client/server operation. Due to how communication is done, there are some error messages from harness that are being suppressed. Indeed, this should be fixed.

Thanks for reporting, @mkenigs

@danrodrig danrodrig self-assigned this Aug 20, 2020
@danrodrig danrodrig added the bug label Aug 20, 2020
@danrodrig
Copy link
Contributor

The fix for this is more complicated that adding a print somewhere. Overall, is about fixing logging in client/server, and going further, the communication between client and server needs to be redesign.

@danrodrig danrodrig removed their assignment Nov 12, 2020
@dav-pascual
Copy link

I came across this issue. It would be good to fix this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants