Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving storage. Moving from TVector3 to ROOT::Math::XYZVector #84

Open
jgalan opened this issue Feb 13, 2024 · 0 comments
Open

Saving storage. Moving from TVector3 to ROOT::Math::XYZVector #84

jgalan opened this issue Feb 13, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@jgalan
Copy link
Member

jgalan commented Feb 13, 2024

We are now using TVector3 data members inside axionlib, however following ROOT pages this class is now obsolete, and the TVector3components are built using Double_t type.

https://root.cern.ch/doc/master/classTVector3.html

They propose to move towards ROOT::Math::XYZVector that can take the form of Float_t type using ROOT::Math::XYZVectorF.

We should update mainy the dadtamembers inside TRestAxionEvent and update rotation and vector operations everywhere where they are used.

Also, the observables could be made float type, just by doing SetObservableValue( "obsName", (Float_t) value );.

Saving space should be also possible by dropping the event data. See issue: rest-for-physics/framework#507

@jgalan jgalan added the enhancement New feature or request label Feb 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant