Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to override retries option on resilient#send and rest of methods. #135

Open
ismriv opened this issue May 28, 2016 · 3 comments
Open

Comments

@ismriv
Copy link

ismriv commented May 28, 2016

I've come across certain use cases where I would like to override the number of retries, configured in the client, on very specific requests, like in the following example, without having to create a new client instance:

client.send(path, {retry: 0, ...}, callback);

If this is currently possible, I didn't manage to get it right ... would this be a reasonable feature to add to resilient.js?

@h2non
Copy link
Contributor

h2non commented May 28, 2016

Yes, it can be achieved easily. Send method can support vadiadic arguments and infer them based of their type.

@h2non
Copy link
Contributor

h2non commented May 28, 2016

@ismriv are you able to provide a PR? Otherwise I can support it in a near future.

@ismriv
Copy link
Author

ismriv commented May 30, 2016

Sure, I'll try to provide a PR by the end of the week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants