Add suppressHydrationWarning to ReactDOM.domProps #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tsnobip
reviewed
May 17, 2024
|
I just ran a cycle of clean and build a few times to see if there is a difference, and it takes about the same time either way, around 250-280ms. |
jderochervlk
force-pushed
the
suppress-hydration-warning
branch
from
4e37e83
to
4b2fe12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this a a good approach, but here's my thoughts:
If we want to make JSX not directly connected to React, we should move React specific JSX props out of the compiler and into React. With the type spreading this is easy to do. There are probably others we could move over here to keep JSX props cleaner, but this seems like a good start.
Fixes #102