From 81a36bb2cc1ea214b1302518cfca7f70bf14e219 Mon Sep 17 00:00:00 2001 From: Andreas Reich Date: Thu, 19 Sep 2024 09:32:37 +0200 Subject: [PATCH] add clarifying comment to sample count --- crates/viewer/re_data_ui/src/blob.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/crates/viewer/re_data_ui/src/blob.rs b/crates/viewer/re_data_ui/src/blob.rs index 206c92951c05..8fd6af24aba4 100644 --- a/crates/viewer/re_data_ui/src/blob.rs +++ b/crates/viewer/re_data_ui/src/blob.rs @@ -186,6 +186,10 @@ fn show_video_blob_info( re_log_types::Duration::from_millis(video.duration().as_ms_f64() as _) ), )); + // Some people may think that num_frames / duration = fps, but that's not true, videos may have variable frame rate. + // At the same time, we don't want to overload users with video codec/container specific stuff that they have to understand, + // and for all intents and purposes one sample = one frame. + // So the compromise is that we truthfully show the number of *samples* here and don't talk about frames. ui.list_item_flat_noninteractive( PropertyContent::new("Sample count") .value_text(format!("{}", video.count_samples())),