From 600919a8eb1f14ffef3ec12aaa9d147d32722b48 Mon Sep 17 00:00:00 2001 From: Andreas Reich Date: Thu, 19 Sep 2024 12:04:55 +0200 Subject: [PATCH] doc fixes --- .../visualizers/utilities/spatial_view_visualizer.rs | 2 +- .../re_space_view_spatial/src/visualizers/videos.rs | 10 ++++------ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/crates/viewer/re_space_view_spatial/src/visualizers/utilities/spatial_view_visualizer.rs b/crates/viewer/re_space_view_spatial/src/visualizers/utilities/spatial_view_visualizer.rs index 82ab6fa4b727..040698533700 100644 --- a/crates/viewer/re_space_view_spatial/src/visualizers/utilities/spatial_view_visualizer.rs +++ b/crates/viewer/re_space_view_spatial/src/visualizers/utilities/spatial_view_visualizer.rs @@ -7,7 +7,7 @@ use crate::{view_kind::SpatialSpaceViewKind, PickableTexturedRect}; /// /// Each spatial scene element is expected to fill an instance of this struct with its data. pub struct SpatialViewVisualizerData { - /// Labels that should be shown rendering egui. + /// Labels that should be shown using egui. pub ui_labels: Vec, /// Bounding boxes of all visualizations that the visualizer showed. diff --git a/crates/viewer/re_space_view_spatial/src/visualizers/videos.rs b/crates/viewer/re_space_view_spatial/src/visualizers/videos.rs index 3bcff758f9b2..47e6547e0765 100644 --- a/crates/viewer/re_space_view_spatial/src/visualizers/videos.rs +++ b/crates/viewer/re_space_view_spatial/src/visualizers/videos.rs @@ -281,12 +281,10 @@ impl VideoFrameReferenceVisualizer { }, ); - let video_error_texture = match video_error_texture_result { - Ok(video_error_texture) => video_error_texture, - Err(err) => { - re_log::error_once!("Failed to show video error icon: {err}"); - return; - } + let Ok(video_error_texture) = video_error_texture_result.inspect_err(|err| { + re_log::error_once!("Failed to show video error icon: {err}"); + }) else { + return; // We failed at failing... }; // Center the icon in the middle of the video rectangle.