Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PR not detected #18

Closed
jeacott1 opened this issue Feb 21, 2023 · 2 comments
Closed

PR not detected #18

jeacott1 opened this issue Feb 21, 2023 · 2 comments
Labels
question Further information is requested

Comments

@jeacott1
Copy link

I notice that in your latest version, referenced PR's are supposed to be linked in the changelog messages where they exist.
Its not working for me.
when I click on the sha link I get taken to a diff page where I can clearly see the PR ref in the corner (eg: main (#16) ), so it does exist.
I'm wondering why my messages are of the format [e0d6403] - my message (commit by @someuser) and not including the PR ref?

I'm triggering the build:

on:
  create:

jobs:
   myjob:
    if: (contains(github.ref, '/tags/v'))
    ...
        id: changelog
        uses: requarks/changelog-action@v1
        with:
          token: ${{ secrets.GITHUB_TOKEN }}
          fromTag: ${{ github.ref_name }}
          toTag: ${{ env.previousTag }}
          excludeTypes: ""
          writeToFile: false
@NGPixel
Copy link
Member

NGPixel commented Feb 22, 2023

Do you have an example repo / release with that behavior?

Here's a working example release with linked PRs:
https://github.com/ietf-tools/datatracker/releases/tag/9.10.0

@jeacott1
Copy link
Author

I can see that its working for you, but it definitely isnt for me.
I dont have a public repo example atm.
have you tried triggering from on: create:? is that the difference?

@NGPixel NGPixel added the question Further information is requested label Mar 17, 2023
@NGPixel NGPixel closed this as not planned Won't fix, can't repro, duplicate, stale Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants