From da9ccfd838fab0fa08c1dbd3f12540206ed7d80c Mon Sep 17 00:00:00 2001 From: maria-hambardzumian Date: Fri, 19 Jul 2024 14:17:20 +0400 Subject: [PATCH] EPMRPP-93055 || code review fix - 1 --- app/src/controllers/uniqueErrors/sagas.js | 10 ++-------- .../uniqueErrorsGrid/uniqueErrorsGrid.jsx | 1 + .../pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx | 10 +++------- 3 files changed, 6 insertions(+), 15 deletions(-) diff --git a/app/src/controllers/uniqueErrors/sagas.js b/app/src/controllers/uniqueErrors/sagas.js index 53bb1d4cb1..ba43be4b48 100644 --- a/app/src/controllers/uniqueErrors/sagas.js +++ b/app/src/controllers/uniqueErrors/sagas.js @@ -17,12 +17,7 @@ import { all, call, put, select, take, takeEvery } from 'redux-saga/effects'; import { URLS } from 'common/urls'; import { activeProjectSelector } from 'controllers/user'; -import { - fetchParentItems, - fetchParentLaunch, - launchSelector, - namespaceSelector, -} from 'controllers/testItem'; +import { fetchParentItems, fetchParentLaunch, launchSelector } from 'controllers/testItem'; import { createFetchPredicate, fetchDataAction } from 'controllers/fetch'; import { launchIdSelector, @@ -83,8 +78,7 @@ function* fetchClusters(payload = {}) { yield call(fetchParentLaunch, { payload: { project, launchId } }); } - const namespace = yield select(namespaceSelector); - const query = yield select(queryParametersSelector, namespace); + const query = yield select(queryParametersSelector, NAMESPACE); let url; const requestParams = {}; const plugin = yield call(getPlugin); diff --git a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx index 9f364026fb..dd06d54081 100644 --- a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx +++ b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx @@ -123,4 +123,5 @@ UniqueErrorsGridWrapped.defaultProps = { export const UniqueErrorsGrid = withSortingURL({ defaultFields: [MATCHED_TESTS_COLUMN_ID], defaultDirection: SORTING_DESC, + namespace: NAMESPACE, })(UniqueErrorsGridWrapped); diff --git a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx index 1ac4f80d92..bc434b099e 100644 --- a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx +++ b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx @@ -18,18 +18,14 @@ import React, { Component } from 'react'; import { PageLayout, PageSection } from 'layouts/pageLayout'; import { connect } from 'react-redux'; import track from 'react-tracking'; -import { - deleteTestItemsAction, - launchSelector, - namespaceSelector, - parentItemSelector, -} from 'controllers/testItem'; +import { deleteTestItemsAction, launchSelector, parentItemSelector } from 'controllers/testItem'; import { clustersSelector, fetchClustersAction, loadingSelector, pageLoadingSelector, uniqueErrorsPaginationSelector, + NAMESPACE, } from 'controllers/uniqueErrors'; import PropTypes from 'prop-types'; import { SpinningPreloader } from 'components/preloaders/spinningPreloader'; @@ -108,7 +104,7 @@ const UNLINK_ISSUE_EVENTS_INFO = { ) @withPagination({ paginationSelector: uniqueErrorsPaginationSelector, - namespaceSelector, + namespace: NAMESPACE, }) @injectIntl @track({ page: UNIQUE_ERRORS_PAGE })