From 9e76eb0e6ed41431de99b038237465b542d7a8a0 Mon Sep 17 00:00:00 2001 From: maria-hambardzumian Date: Tue, 23 Jul 2024 19:14:28 +0400 Subject: [PATCH] EPMRPP-93091 | conde review -1 --- .../clusterItemsGridRow/clusterItemsGridRow.jsx | 14 ++------------ .../clusterItemsGridRow/clusterItemsGridRow.scss | 4 ---- .../uniqueErrorsGrid/uniqueErrorsGrid.jsx | 7 ++----- .../uniqueErrorsGrid/uniqueErrorsGrid.scss | 6 +----- 4 files changed, 5 insertions(+), 26 deletions(-) diff --git a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.jsx b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.jsx index 34b63e72ae..86b773c324 100644 --- a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.jsx +++ b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.jsx @@ -75,13 +75,7 @@ ClusterColumn.defaultProps = { cluster: {}, }; -export const ClusterItemsGridRow = ({ - data, - onEditItem, - onUnlinkSingleTicket, - onEditDefect, - isSelectedOptionAll, -}) => { +export const ClusterItemsGridRow = ({ data, onEditItem, onUnlinkSingleTicket, onEditDefect }) => { const { id, matchedTests } = data; const { formatMessage } = useIntl(); const dispatch = useDispatch(); @@ -140,10 +134,7 @@ export const ClusterItemsGridRow = ({ {extensions.map((extension) => ( -
+
))} @@ -206,7 +197,6 @@ ClusterItemsGridRow.propTypes = { onEditItem: PropTypes.func, onUnlinkSingleTicket: PropTypes.func, onEditDefect: PropTypes.func, - isSelectedOptionAll: PropTypes.bool, }; ClusterItemsGridRow.defaultProps = { data: {}, diff --git a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.scss b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.scss index c3a5245ba2..f76cdd8eda 100644 --- a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.scss +++ b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/clusterItemsGridRow/clusterItemsGridRow.scss @@ -36,11 +36,7 @@ } &.extension-col { - width: 130px; - - &.large { width: 165px; - } } } diff --git a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx index f8ba375519..ca1b2b8c60 100644 --- a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx +++ b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.jsx @@ -34,13 +34,11 @@ import styles from './uniqueErrorsGrid.scss'; const cx = classNames.bind(styles); const MATCHED_TESTS_COLUMN_ID = 'matchedTests'; -const ALL_UNIQUE_ERRORS = 'all'; export const UniqueErrorsGridWrapped = ({ parentLaunch, data, loading, ...rest }) => { const { formatMessage } = useIntl(); const query = useSelector(querySelector); const hasNamespacedQuery = Object.keys(extractNamespacedQuery(query, NAMESPACE)).length; - const { mode: selectedErrorType = ALL_UNIQUE_ERRORS } = extractNamespacedQuery(query, NAMESPACE); const extensions = useSelector(uniqueErrorGridHeaderCellComponentSelector); const columns = [ { @@ -69,7 +67,7 @@ export const UniqueErrorsGridWrapped = ({ parentLaunch, data, loading, ...rest } return extensions.map((extension) => { const MemoizedComponent = (params) => ( -
+
); @@ -80,7 +78,7 @@ export const UniqueErrorsGridWrapped = ({ parentLaunch, data, loading, ...rest } }, }; }); - }, [extensions, selectedErrorType]); + }, [extensions]); columns.push(...memoizedExtensionsColumns, { id: MATCHED_TESTS_COLUMN_ID, @@ -107,7 +105,6 @@ export const UniqueErrorsGridWrapped = ({ parentLaunch, data, loading, ...rest } loading={loading} nestedGridRow={ClusterItemsGridRow} nestedView - isSelectedOptionAll={selectedErrorType === ALL_UNIQUE_ERRORS} {...rest} /> {!loading && !data.length && ( diff --git a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.scss b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.scss index eead18b10a..274dd026ed 100644 --- a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.scss +++ b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsGrid/uniqueErrorsGrid.scss @@ -27,9 +27,5 @@ } .extension-col{ - width: 130px; - - &.large{ - width: 165px; - } + width: 165px; }