From 88b30a421ac2ca1500840a0349dacddb189d0856 Mon Sep 17 00:00:00 2001 From: Iukou Siarhei <45054016+BlazarQSO@users.noreply.github.com> Date: Tue, 28 Nov 2023 11:34:46 +0300 Subject: [PATCH] EPMRPP-83275 || extra GA event is sent when selecting edit defects option (#3675) --- .../events/common/testItemPages/actionEventsCreators.js | 5 ----- .../components/main/analytics/events/historyPageEvents.js | 2 -- app/src/components/main/analytics/events/stepPageEvents.js | 2 -- .../main/analytics/events/uniqueErrorsPageEvents.js | 2 -- .../actionPanelWithGroupOperations.jsx | 1 - app/src/pages/inside/stepPage/stepPage.jsx | 4 +--- app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx | 2 -- 7 files changed, 1 insertion(+), 17 deletions(-) diff --git a/app/src/components/main/analytics/events/common/testItemPages/actionEventsCreators.js b/app/src/components/main/analytics/events/common/testItemPages/actionEventsCreators.js index 3e5a3c732b..accdc63eba 100644 --- a/app/src/components/main/analytics/events/common/testItemPages/actionEventsCreators.js +++ b/app/src/components/main/analytics/events/common/testItemPages/actionEventsCreators.js @@ -149,11 +149,6 @@ export const getDeleteActionEvent = (category) => ({ element_name: 'delete', }); -export const getEditDefectActionEvent = (category) => ({ - ...getClickListOfActionsEventCreator(category), - element_name: 'edit_defects', -}); - export const getPostIssueActionEvent = (category) => ({ ...getClickListOfActionsEventCreator(category), element_name: 'post_issue', diff --git a/app/src/components/main/analytics/events/historyPageEvents.js b/app/src/components/main/analytics/events/historyPageEvents.js index 2aa7cc1b48..7d91cd4cde 100644 --- a/app/src/components/main/analytics/events/historyPageEvents.js +++ b/app/src/components/main/analytics/events/historyPageEvents.js @@ -16,7 +16,6 @@ import { getDeleteActionEvent, - getEditDefectActionEvent, getLinkIssueActionEvent, getUnlinkIssueActionEvent, getPostIssueActionEvent, @@ -87,7 +86,6 @@ export const HISTORY_PAGE_EVENTS = { }, TEST_ITEM_TABS_EVENTS: getClickOnTestItemsTabsEvents(HISTORY_PAGE), EDIT_ITEMS_ACTION, - EDIT_DEFECT_ACTION: getEditDefectActionEvent(HISTORY_PAGE), POST_ISSUE_ACTION: getPostIssueActionEvent(HISTORY_PAGE), LINK_ISSUE_ACTION: getLinkIssueActionEvent(HISTORY_PAGE), DELETE_ACTION: getDeleteActionEvent(HISTORY_PAGE), diff --git a/app/src/components/main/analytics/events/stepPageEvents.js b/app/src/components/main/analytics/events/stepPageEvents.js index dce9adb952..ea78201823 100644 --- a/app/src/components/main/analytics/events/stepPageEvents.js +++ b/app/src/components/main/analytics/events/stepPageEvents.js @@ -15,7 +15,6 @@ */ import { getBasicClickEventParameters } from './common/ga4Utils'; import { - getEditDefectActionEvent, getDeleteActionEvent, getLinkIssueActionEvent, getPostIssueActionEvent, @@ -105,7 +104,6 @@ export const STEP_PAGE_EVENTS = { switcher: isActive ? 'on' : 'off', }), DELETE_ACTION: getDeleteActionEvent(STEP_PAGE), - EDIT_DEFECT_ACTION: getEditDefectActionEvent(STEP_PAGE), POST_ISSUE_ACTION: getPostIssueActionEvent(STEP_PAGE), LINK_ISSUE_ACTION: getLinkIssueActionEvent(STEP_PAGE), UNLINK_ISSUES_ACTION: getUnlinkIssueActionEvent(STEP_PAGE), diff --git a/app/src/components/main/analytics/events/uniqueErrorsPageEvents.js b/app/src/components/main/analytics/events/uniqueErrorsPageEvents.js index 4ab46c142a..c818ec4aad 100644 --- a/app/src/components/main/analytics/events/uniqueErrorsPageEvents.js +++ b/app/src/components/main/analytics/events/uniqueErrorsPageEvents.js @@ -35,7 +35,6 @@ import { getChangeItemStatusEventCreator, getIgnoreInAutoAnalysisActionEventCreator, getIncludeInAutoAnalysisActionEventCreator, - getEditDefectActionEvent, } from './common/testItemPages/actionEventsCreators'; import { getClickOnAnalyzeUniqueErrorsEventCreator, @@ -82,7 +81,6 @@ export const UNIQUE_ERRORS_PAGE_EVENTS = { DELETE_ACTION: getDeleteActionEvent(UNIQUE_ERRORS_PAGE), IGNORE_IN_AA_ACTION: getIgnoreInAutoAnalysisActionEventCreator(UNIQUE_ERRORS_PAGE), INCLUDE_IN_AA_ACTION: getIncludeInAutoAnalysisActionEventCreator(UNIQUE_ERRORS_PAGE), - EDIT_DEFECT_ACTION: getEditDefectActionEvent(UNIQUE_ERRORS_PAGE), IGNORE_BTN_IGNORE_ITEMS_IN_AA_MODAL: getIgnoreBtnIgnoreItemsInAAModalEvent(UNIQUE_ERRORS_PAGE), POST_ISSUE_MODAL_EVENTS: getPostIssueModalEvents(UNIQUE_ERRORS_PAGE), LINK_ISSUE_MODAL_EVENTS: getLinkIssueModalEvents(UNIQUE_ERRORS_PAGE), diff --git a/app/src/pages/inside/historyPage/historyToolbar/actionPanelWithGroupOperations/actionPanelWithGroupOperations.jsx b/app/src/pages/inside/historyPage/historyToolbar/actionPanelWithGroupOperations/actionPanelWithGroupOperations.jsx index 568f66f788..9fbfa64bbe 100644 --- a/app/src/pages/inside/historyPage/historyToolbar/actionPanelWithGroupOperations/actionPanelWithGroupOperations.jsx +++ b/app/src/pages/inside/historyPage/historyToolbar/actionPanelWithGroupOperations/actionPanelWithGroupOperations.jsx @@ -303,7 +303,6 @@ export class ActionPanelWithGroupOperations extends Component { 'actions', ), ); - tracking.trackEvent(HISTORY_PAGE_EVENTS.EDIT_DEFECT_ACTION); onEditDefects(items, { fetchFunc: this.unselectAndRefreshItems, diff --git a/app/src/pages/inside/stepPage/stepPage.jsx b/app/src/pages/inside/stepPage/stepPage.jsx index 11cde22120..4c458a0d7e 100644 --- a/app/src/pages/inside/stepPage/stepPage.jsx +++ b/app/src/pages/inside/stepPage/stepPage.jsx @@ -343,12 +343,10 @@ export class StepPage extends Component { }; handleEditDefects = (eventData) => { - const { selectedItems, tracking } = this.props; + const { selectedItems } = this.props; const items = eventData && eventData.id ? [eventData] : selectedItems; const MAKE_DECISION = 'make_decision'; - tracking.trackEvent(STEP_PAGE_EVENTS.EDIT_DEFECT_ACTION); - this.props.editDefectsAction(items, { fetchFunc: this.unselectAndFetchItems, eventsInfo: { diff --git a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx index 8cb3926bae..4a9c0df8c9 100644 --- a/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx +++ b/app/src/pages/inside/uniqueErrorsPage/uniqueErrorsPage.jsx @@ -217,8 +217,6 @@ export class UniqueErrorsPage extends Component { const { selectedItems, tracking } = this.props; const items = eventData && eventData.id ? [eventData] : selectedItems; - tracking.trackEvent(UNIQUE_ERRORS_PAGE_EVENTS.EDIT_DEFECT_ACTION); - tracking.trackEvent( UNIQUE_ERRORS_PAGE_EVENTS.MAKE_DECISION_MODAL_EVENTS.getOpenModalEvent( items.length === 1