Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address all Rubocop TODOs #48

Open
1 of 49 tasks
abotalov opened this issue Jun 20, 2019 · 0 comments
Open
1 of 49 tasks

Address all Rubocop TODOs #48

abotalov opened this issue Jun 20, 2019 · 0 comments
Labels
enhancement help wanted

Comments

@abotalov
Copy link
Member

abotalov commented Jun 20, 2019 •
edited
Loading

Rubocop was introduced in #43.
We should address TODOs one by one - create a PR per one / several offenses to ease reviewing.

  • Layout/AlignArguments
  • Layout/EmptyLineAfterGuardClause
  • Layout/ExtraSpacing
  • Layout/LeadingCommentSpace
  • Layout/MultilineOperationIndentation
  • Layout/SpaceAfterComma
  • Layout/SpaceAroundEqualsInParameterDefault
  • Layout/SpaceAroundOperators
  • Layout/SpaceInsideBlockBraces
  • Layout/SpaceInsideHashLiteralBraces
  • Layout/TrailingWhitespace
  • Lint/ParenthesesAsGroupedExpression
  • Lint/UnneededRequireStatement
  • Lint/UriEscapeUnescape
  • Metrics/AbcSize
  • Metrics/BlockLength
  • Metrics/ClassLength
  • Metrics/CyclomaticComplexity
  • Metrics/MethodLength
  • Metrics/ModuleLength
  • Metrics/PerceivedComplexity
  • Naming/UncommunicativeMethodParamName
  • Security/YAMLLoad
  • Style/BracesAroundHashParameters
  • Style/CommentedKeyword
  • Style/ConditionalAssignment
  • Style/Documentation
  • Style/EmptyElse
  • Style/ExpandPathArguments
  • Style/FormatString
  • Style/FormatStringToken
  • Style/FrozenStringLiteralComment
  • Style/GlobalVars
  • Style/GuardClause
  • Style/HashSyntax
  • Style/IfUnlessModifier
  • Style/ModuleFunction
  • Style/MutableConstant
  • Style/NumericPredicate
  • Style/PercentLiteralDelimiters
  • Style/RescueStandardError
  • Style/SafeNavigation
  • Style/SignalException
  • Style/SpecialGlobalVars
  • Style/StringLiterals
  • Style/SymbolArray
  • Style/TernaryParentheses
  • Style/TrailingCommaInHashLiteral
  • Metrics/LineLength
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@abotalov