Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bug: Remove duplicate results in preflights #1626

Merged
merged 1 commit into from
Sep 26, 2024
Merged

bug: Remove duplicate results in preflights #1626

merged 1 commit into from
Sep 26, 2024

Conversation

banjoh
Copy link
Member

@banjoh banjoh commented Sep 26, 2024 •
edited
Loading

Description, Motivation and Context

Change to stop re-analysing preflight results when uploadResultsTo is present

Before
https://asciinema.org/a/Bo9k5KxeAjXTKGkdLzDKYJGj7

After
https://asciinema.org/a/XXflLFUP5mv1r90KB1Ae9V3cF

Fixes: #1625

Checklist

  • New and existing tests pass locally with introduced changes.
  • Tests for the changes have been added (for bug fixes / features)
  • The commit message(s) are informative and highlight any breaking changes
  • Any documentation required has been added/updated. For changes to https://troubleshoot.sh/ create a PR here

Does this PR introduce a breaking change?

  • Yes
  • No

@banjoh banjoh added type::bug Something isn't working bug::regression labels Sep 26, 2024
@banjoh banjoh requested a review from a team as a code owner September 26, 2024 12:55
hedge-sparrow
hedge-sparrow approved these changes Sep 26, 2024
View reviewed changes
Copy link
Member

@hedge-sparrow hedge-sparrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@banjoh banjoh merged commit 2bb611c into replicatedhq:main Sep 26, 2024
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hedge-sparrow hedge-sparrow hedge-sparrow approved these changes

Assignees
No one assigned
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Failing analysis results appear when running preflights
2 participants
@banjoh @hedge-sparrow