Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mergable specs missing some collectors if one of the specs has a uri field #1540

Closed
banjoh opened this issue May 1, 2024 · 1 comment
Closed
Labels
bug::regression type::bug Something isn't working

Comments

@banjoh
Copy link
Member

banjoh commented May 1, 2024

Bug Description

When merging specs, and one of the specs happens to be updatable i.e has the uri field defined, the resulting merged spec ends up missing some of the collectors defined.

Expected Behavior

All specs (collectors/analysers/redactors) should be present in the merged spec.

Steps To Reproduce

Create sample data spec

cat << EOF > spec.yaml
apiVersion: troubleshoot.sh/v1beta2
kind: SupportBundle
spec:
  collectors:
    - data:
        name: sample-data.txt
        data: |
          any static
          data can be used here
EOF

Using the newest version of support-bundle, dry-run using the command below and search for sample-data.txt. Note that sample-data.txt is missing

[evans] $ support-bundle version
Replicated Troubleshoot v0.91.0
[evans] $ support-bundle --dry-run spec.yaml https://raw.githubusercontent.com/replicatedhq/troubleshoot-specs/main/in-cluster/default.yaml | grep sample-data.txt; echo $?
1

In an older version of support bundle, this issue is absent

[evans] $ support-bundle version
Replicated Troubleshoot v0.90.0
[evans] $ support-bundle --dry-run spec.yaml https://raw.githubusercontent.com/replicatedhq/troubleshoot-specs/main/in-cluster/default.yaml | grep sample-data.txt
      name: sample-data.txt
@banjoh
Copy link
Member Author

banjoh commented May 21, 2024

v0.92.0 seems to have this bug fixed.

$ support-bundle version
Replicated Troubleshoot v0.92.0
$ support-bundle --dry-run spec.yaml https://raw.githubusercontent.com/replicatedhq/troubleshoot-specs/main/in-cluster/default.yaml | grep sample-data.txt;
      name: sample-data.txt

@banjoh banjoh closed this as completed May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug::regression type::bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant