Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing highlighting for custom keywords #203

Open
multimokia opened this issue Sep 20, 2022 · 2 comments
Open

Missing highlighting for custom keywords #203

multimokia opened this issue Sep 20, 2022 · 2 comments
Labels
backlog Something that is not a priority and will be addressed in a future release feature-request topic:syntax

Comments

@multimokia
Copy link
Contributor

Extension version

2.1.2

Issue description

Custom defined expressions don't have highlighting for their keyword, nor associated keywords (i.e. expression), for example:
image

Where jarg is a variation on jump which allows args, it'd be nice if custom expressions were consistent with builtins for how they're highlighted.

Scope inspector screenshots

image
image
image

Code

Definition code here: https://github.com/Monika-After-Story/MonikaModDev/pull/9413/files#diff-625c1ad3cf06b07c6a42d812c5faa1df8443d2bd22d8270fdc0e61d735021f02

For the in-rpy view:

label test:
    call expression "dev_unit_test_jump_with_args_depth_2" pass ("a", "b")
    jarg expression "dev_unit_test_jump_with_args_depth_2" pass ("brand_new_foo_value", "brand_new_bar_value")
@rdurfee
Copy link
Collaborator

rdurfee commented Sep 20, 2022

"jarg" is not a valid RenPy keyword. Is it a creator defined statement? The extension doesn't have a lot of support for those yet.

@multimokia
Copy link
Contributor Author

Yes, that is what I meant by custom keyword, I guess in a sense this is more of a feature req, my mistake

@duckdoom4 duckdoom4 added the backlog Something that is not a priority and will be addressed in a future release label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Something that is not a priority and will be addressed in a future release feature-request topic:syntax
Projects
None yet
Development

No branches or pull requests

4 participants