Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RAPT space usage and post-build cleanup #24

Open
korden32 opened this issue Apr 14, 2021 · 2 comments
Open

RAPT space usage and post-build cleanup #24

korden32 opened this issue Apr 14, 2021 · 2 comments

Comments

@korden32
Copy link

RAPT doesn't clean assets after build and SDK folder quickly becomes very huge (at least x5 size of the base game).

I'm talking about:

rapt/bin/*.apk
rapt/project/app/build/outputs/apk/*/*.apk

Any reasons not to use shutil.move instead of copy? Same for moving from rapt/bin to workdir/GAME-dists.

rapt/project/app/src/main/assets/*
rapt/project/app/build/intermediates/merged_assets/release/out/*
tmp/*/android.dist/assets*

Any downsides in cleaning everything after successful build?
Again - maybe move instead of copy at some steps? (like in make_tree). That will save space required for compilation.

@Selenyhr
Copy link

RAPT not clearing the assets causes issues with the following cases:

  • building different games with the same RAPT install. All of the following APKs take the name and icon of the first game built.
  • modifying a game name after the first build (in case game creators want to include the version number in the name for example)
  • modifying a game icon after the first build (in case the icon does not look the way we'd like)

Currently, the best way I've found for working around these issues is to straight-up back-up the developer keys, remove the entire rapt folder in the Ren'Py install, and reinstall RAPT from scratch, then importing back the keys.

Could anyone see what could be done so that the APK build process is more streamlined, and would not require the user to remove some files afterwards please?

@do10HM
Copy link

do10HM commented Feb 28, 2024

+1 on these issues, especially those @Selenyhr mentioned.

Is there a reason that RAPT uses the ren'py folder as its workspace when building a project? Shouldn't it copy the template files into a new per-project folder (if they don't already exist) and allow for those to be edited after the fact?

Also feels really strange that the contents of android.json aren't injected at build-time. For instance, if you change your bundle id, it isn't reflected in the outputted APK.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants