Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only pass docker env to docker cli instead of all childs #9088

Open
1 of 5 tasks
viceice opened this issue Mar 11, 2021 · 2 comments
Open
1 of 5 tasks

Only pass docker env to docker cli instead of all childs #9088

viceice opened this issue Mar 11, 2021 · 2 comments
Assignees
@viceice
Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:bug Bug fix of existing functionality

Comments

@viceice
Copy link
Member

viceice commented Mar 11, 2021

What Renovate type, platform and version are you using?

all, doesn't matter

Describe the bug

Currenly renovate pass all docker cli related env to all child process. We should only pass those to the docker cli call when trustLevel!=high

Relevant debug logs

Have you created a minimal reproduction repository?

Please read the minimal reproductions documentation to learn how to make a good minimal reproduction repository.

  • This is a really small bug, it does not need a reproduction (think small typo)
  • I have provided a minimal reproduction repository
  • I don't have time for that, but it happens in a public repository I have linked to
  • I don't have time for that, and cannot share my private repository
  • The nature of this bug means it's impossible to reproduce publicly

Additional context
@viceice viceice added type:bug Bug fix of existing functionality status:requirements Full requirements are not yet known, so implementation should not be started priority-5-triage priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others and removed priority-5-triage status:requirements Full requirements are not yet known, so implementation should not be started labels Mar 11, 2021
@rarkins rarkins added status:requirements Full requirements are not yet known, so implementation should not be started and removed status:ready labels Jan 13, 2022
@rarkins
Copy link
Collaborator

rarkins commented Apr 21, 2023

@viceice is this still valid?

@viceice
Copy link
Member Author

viceice commented Apr 21, 2023

yes

@rarkins rarkins added status:ready and removed status:requirements Full requirements are not yet known, so implementation should not be started labels Apr 22, 2023
@rarkins rarkins added priority-4-low Low priority, unlikely to be done unless it becomes important to more people and removed priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others labels Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viceice viceice

Labels
priority-4-low Low priority, unlikely to be done unless it becomes important to more people type:bug Bug fix of existing functionality
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@viceice @rarkins