Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump semantic-release to 23.1.0, and update our configuration file(s) #29118

Closed
HonkingGoose opened this issue May 16, 2024 · 3 comments
Closed
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code

Comments

@HonkingGoose
Copy link
Collaborator

Describe the proposed change(s).

Semantic Release v23.1.0 has this change:

add main branch to default release branch config

I think this means we do no longer need to explicitly define the main branch, in this file?

renovate/.releaserc.json

Lines 93 to 96 in 8bbde23

"branches": [
{
"name": "main"
}

Maybe there are other Semantic Release config files that we should update, that I'm forgetting to list. 😉

Context:

@HonkingGoose HonkingGoose added priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code labels May 16, 2024
@viceice
Copy link
Member

viceice commented May 16, 2024

we need to wait until we're using node v20 on CI, so semantic release v23 is still blocked

@HonkingGoose
Copy link
Collaborator Author

Our build.yml workflow file now sets node to 20 in its environment.

Are we ready to upgrade semantic-release?

@viceice
Copy link
Member

viceice commented Aug 2, 2024

yes, already done

@viceice viceice closed this as completed Aug 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
priority-3-medium Default priority, "should be done" but isn't prioritised ahead of others type:refactor Refactoring or improving of existing code
Projects
None yet
Development

No branches or pull requests

2 participants