-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for pnpm.overrides #17298
Comments
Is automatic update of overrides really something that's wanted? As those are (usually at least) used to select working version for some transient dependency, so offering update to those automatically feels some thing that would easily break things. Relates to projen/projen#2126 I know that npm has those, but it just backfired today as we have a lot of "garbage" PRs due to updated trying to touch resolutions (and breaking the build as Projen puts those back causing git's mutability check to fail) |
I think we should make sure we have adequate metadata (e.g. |
while I agree that something like |
Do we need to extract dependencies from the |
always update the override, they don't need to be in normal dependencies. they are independent and mostly transitive deps. |
This comment was marked as spam.
This comment was marked as spam.
As more users are switching to pnpm in the ecosystem, this issue will gain more attention over time, and potentially community contributors. Is there a recommended path for community contributions here? Should the Renovate implementation of npm Overrides and Yarn Resolutions be copied to support pnpm Overrides too? |
Yes, it should be mostly a copy paste of the same concept from npm/yarn |
🎉 This issue has been resolved in version 37.281.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What would you like Renovate to be able to do?
I would like Renovate to be able to deal with pnpm.overrides the same way it does for overrides.
Currently, when renovate updates a dependency, it will also change the version of that dependency on the overrides section, but will ignore the pnpm.overrides section.
I've set up a repository to reproduce the current behaviour:
Repo: https://github.com/fantun3s/SIMPLE-PNPM-RENOVATE
PR: https://github.com/fantun3s/SIMPLE-PNPM-RENOVATE/pull/4
If you have any ideas on how this should be implemented, please tell us here.
I believe the same logic that is already in place to handle the overrides property can be reused for pnpm.overrides.
Is this a feature you are interested in implementing yourself?
Maybe
The text was updated successfully, but these errors were encountered: