Skip to content

Commit c36d588

Browse files
[ci] Fix binary-size-check workflow (jaegertracing#6552)
## Which problem is this PR solving? - Fix for one issue caused in jaegertracing#6527 ## Description of the changes - cache_output not being set after a cache hit using restore key - Instead check for cache-matched-key != ''" ## How was this change tested? - ## Checklist - [ ] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [ ] I have signed all commits - [ ] I have added unit tests for the new functionality - [ ] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` Signed-off-by: chahatsagarmain <[email protected]>
1 parent 4745045 commit c36d588

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci-lint-checks.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -155,7 +155,7 @@ jobs:
155155
jaeger_binary_size
156156
157157
- name: Compare jaeger binary sizes
158-
if: steps.cache-binary-size.outputs.cache-hit == 'true'
158+
if: steps.cache-binary-size.outputs.cache-matched-key != ''
159159
run: |
160160
OLD_BINARY_SIZE=$(cat ./jaeger_binary_size.txt)
161161
NEW_BINARY_SIZE=$(cat ./new_jaeger_binary_size.txt)

0 commit comments

Comments
 (0)