Skip to content

Commit 4fbffc9

Browse files
authored
[storage]Generate mocks for dependency writer of v2 (jaegertracing#6576)
## Which problem is this PR solving? A minor fix related to jaegertracing#6559 ## Description of the changes - On addition of dependency writer in storage v2, mocks generation was left which is generating mocks when `make generate mocks` is ran on main branch which can cause unnecessary noise in a PR which is adding mocks ## How was this change tested? - unit tests ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `npm run lint` and `npm run test` --------- Signed-off-by: Manik2708 <[email protected]>
1 parent 976a36e commit 4fbffc9

File tree

2 files changed

+53
-1
lines changed

2 files changed

+53
-1
lines changed

.github/workflows/ci-lint-checks.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -92,7 +92,7 @@ jobs:
9292
run: make thrift && git diff --name-status --exit-code
9393

9494
- name: Verify Mockery types are up to date
95-
run: make generate-mocks && git diff --name-status --exit-code
95+
run: make generate-mocks && { if git status --porcelain | grep '??'; then exit 1; else git diff --name-status --exit-code; fi }
9696

9797
lint-shell-scripts:
9898
runs-on: ubuntu-latest

storage_v2/depstore/mocks/Writer.go

+52
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)