diff --git a/.golangci.yml b/.golangci.yml index b17eefcb0d..750314c0e8 100644 --- a/.golangci.yml +++ b/.golangci.yml @@ -44,6 +44,7 @@ linters: - unconvert # Remove unnecessary type conversions [fast: false, auto-fix: false] - unparam # Reports unused function parameters [fast: false, auto-fix: false] - unused #(megacheck): Checks Go code for unused constants, variables, functions and types [fast: false, auto-fix: false] + - wastedassign # wastedassign finds wasted assignment statements. [fast: false, auto-fix: false] - whitespace # Tool for detection of leading and trailing whitespace [fast: true, auto-fix: true] - zerologlint # Detects the wrong usage of `zerolog` that a user forgets to dispatch with `Send` or `Msg` [fast: false, auto-fix: false] diff --git a/internal/human/marshal.go b/internal/human/marshal.go index f0bb8c0702..1d6606e0ac 100644 --- a/internal/human/marshal.go +++ b/internal/human/marshal.go @@ -319,7 +319,7 @@ func marshalSlice(slice reflect.Value, opt *MarshalOpt) (string, error) { } fieldValue := reflect.ValueOf(v) - str := "" + var str string switch { // Handle inline slice. case fieldValue.Type().Kind() == reflect.Slice: diff --git a/internal/interactive/prompt.go b/internal/interactive/prompt.go index 6194da040b..36275233c2 100644 --- a/internal/interactive/prompt.go +++ b/internal/interactive/prompt.go @@ -145,7 +145,7 @@ func Readline(config *ReadlineConfig) (string, error) { } promptHandler = &ReadlineHandler{rl: rl} - s := "" + var s string for { s, err = rl.Readline() // If readline returns an error we return it diff --git a/internal/namespaces/object/v1/s3_helpers.go b/internal/namespaces/object/v1/s3_helpers.go index 5c267023bb..642e02963b 100644 --- a/internal/namespaces/object/v1/s3_helpers.go +++ b/internal/namespaces/object/v1/s3_helpers.go @@ -24,7 +24,7 @@ func newS3Client(ctx context.Context, region scw.Region) *s3.Client { return nil } - customEndpoint := "" + var customEndpoint string if ep := os.Getenv("SCW_S3_ENDPOINT"); ep != "" { customEndpoint = ep } else { diff --git a/internal/namespaces/rdb/v1/custom_acl.go b/internal/namespaces/rdb/v1/custom_acl.go index 599ccabea4..584a60a180 100644 --- a/internal/namespaces/rdb/v1/custom_acl.go +++ b/internal/namespaces/rdb/v1/custom_acl.go @@ -196,7 +196,7 @@ func aclDeleteBuilder(c *core.Command) *core.Command { return nil, fmt.Errorf("failed to remove ACL rule: %w", err) } - message := "" + var message string if ruleWasSet { message = fmt.Sprintf("ACL rule %s successfully deleted", args.ACLRuleIPs.String()) } else { diff --git a/internal/namespaces/rdb/v1/custom_instance.go b/internal/namespaces/rdb/v1/custom_instance.go index c3fd843a88..999a1a0ecb 100644 --- a/internal/namespaces/rdb/v1/custom_instance.go +++ b/internal/namespaces/rdb/v1/custom_instance.go @@ -652,7 +652,7 @@ Learn more at: https://dev.mysql.com/doc/refman/8.0/en/option-files.html` ) func passwordFileExist(ctx context.Context, family engineFamily) bool { - passwordFilePath := "" + var passwordFilePath string switch family { case PostgreSQL: switch runtime.GOOS { diff --git a/internal/qa/ignore.go b/internal/qa/ignore.go index de3fe5649b..4d155b5c04 100644 --- a/internal/qa/ignore.go +++ b/internal/qa/ignore.go @@ -19,7 +19,7 @@ func filterIgnore(unfilteredErrors []error) []error { func isIgnoredError(err error) bool { for _, ignoredError := range ignoredErrors { - isEqual := false + var isEqual bool switch typedError := err.(type) { case *DifferentLocalizationForNamespaceError: isEqual = areCommandsEquals(typedError.Command1, ignoredError.Command) || areCommandsEquals(typedError.Command2, ignoredError.Command)