Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor repeat_start needed #20

Open
bwookieeeee opened this issue Nov 20, 2019 · 3 comments
Open

Refactor repeat_start needed #20

bwookieeeee opened this issue Nov 20, 2019 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@bwookieeeee
Copy link
Member

When a robot fails to enter a ready state, it should not say the boot message. That is to say, when a robot fails to authenticate, it should not continue saying "OK" until it's killed.

This appears to be somewhat addressed in networking.py, however I've failed to observe the termination actually terminating; although it may be an overzealous repeat_start starting the script after it's terminated, I'm not quite sure.

@bwookieeeee bwookieeeee added the bug Something isn't working label Nov 20, 2019
@Nocturnal42
Copy link
Collaborator

This is in part because the boot message is in the internetStatus function, and not actually linked to the bot authenticating to the site. I was surprised when you added a customized boot message that you did not move it somewhere more appropriate.

The other reason is repeat_start. The internet status function runs by default at 120 second intervals, so unless it's been dropped to something unreasonably low, the controller is being terminated and restarted and thus repeating the message.

@bwookieeeee
Copy link
Member Author

bwookieeeee commented Nov 21, 2019 via email

@bwookieeeee bwookieeeee self-assigned this Nov 21, 2019
@bwookieeeee
Copy link
Member Author

Looks like it's actually an issue with repeat_start. Not sure what to do about that...

@bwookieeeee bwookieeeee changed the title Relocate boot message or terminate on startup error Refactor repeat_start needed Dec 9, 2019
MrSpoon added a commit to MrSpoon/controller that referenced this issue Apr 20, 2021
Misread the problem on issue remotv#20. It was not an issue with the tts but with a continuous restarting loop due to api authentication failure.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants