We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://stackblitz.com/edit/remix-run-remix-wdqegrhk?file=server.mjs
All systems
npm
Closing the Vite dev server should clean up the Remix plugin viteChildCompiler and the routesViteNodeContext
In reproduction, you can see a listener for SIGTERM that is left behind on each close of the vit dev server
SIGTERM
Closing the Vit dev server only cleans up viteChildCompiler
Plugin clean up: https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/plugin.ts#L1514
There is also a routesViteNodeContext created: https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/plugin.ts#L1049
which creates its own dev server which is not closed: https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/vite-node.ts#L20
The text was updated successfully, but these errors were encountered:
I think the fix is as simple as
async buildEnd() { await viteChildCompiler?.close(); await routesViteNodeContext.devServer.close(); },
Sorry, something went wrong.
No branches or pull requests
Reproduction
https://stackblitz.com/edit/remix-run-remix-wdqegrhk?file=server.mjs
System Info
Used Package Manager
npm
Expected Behavior
Closing the Vite dev server should clean up the Remix plugin viteChildCompiler and the routesViteNodeContext
In reproduction, you can see a listener for
SIGTERM
that is left behind on each close of the vit dev serverActual Behavior
Closing the Vit dev server only cleans up viteChildCompiler
Plugin clean up:
https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/plugin.ts#L1514
There is also a routesViteNodeContext created:
https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/plugin.ts#L1049
which creates its own dev server which is not closed:
https://github.com/remix-run/remix/blob/main/packages/remix-dev/vite/vite-node.ts#L20
The text was updated successfully, but these errors were encountered: