From b94e2233d7b4dd06bf20fa1a958bab0c53166e2a Mon Sep 17 00:00:00 2001 From: reda <47112551+redabacha@users.noreply.github.com> Date: Mon, 2 Sep 2024 11:17:36 +0100 Subject: [PATCH] Don't pass --node-modules-dir flag to deno install --- packages/create-remix/__tests__/create-remix-test.ts | 6 +----- .../fixtures/successful-remix-init-deno/deno.json | 1 + packages/create-remix/index.ts | 7 +------ 3 files changed, 3 insertions(+), 11 deletions(-) diff --git a/packages/create-remix/__tests__/create-remix-test.ts b/packages/create-remix/__tests__/create-remix-test.ts index bfca48518f5..56d3a88f3f0 100644 --- a/packages/create-remix/__tests__/create-remix-test.ts +++ b/packages/create-remix/__tests__/create-remix-test.ts @@ -926,11 +926,7 @@ describe("create-remix CLI", () => { expect(execa).toHaveBeenCalledWith( "deno", - expect.arrayContaining([ - "install", - "--node-modules-dir=true", - "--no-lock", - ]), + expect.arrayContaining(["install", "--no-lock"]), expect.objectContaining({ env: { DENO_FUTURE: "1" } }) ); delete process.versions.deno; diff --git a/packages/create-remix/__tests__/fixtures/successful-remix-init-deno/deno.json b/packages/create-remix/__tests__/fixtures/successful-remix-init-deno/deno.json index c21609d0df5..8a5b60867ac 100644 --- a/packages/create-remix/__tests__/fixtures/successful-remix-init-deno/deno.json +++ b/packages/create-remix/__tests__/fixtures/successful-remix-init-deno/deno.json @@ -1,4 +1,5 @@ { + "nodeModulesDir": true, "imports": { "is-odd": "npm:is-odd@3.0.1" } diff --git a/packages/create-remix/index.ts b/packages/create-remix/index.ts index e2225d8fa96..2327c5760b2 100644 --- a/packages/create-remix/index.ts +++ b/packages/create-remix/index.ts @@ -672,12 +672,7 @@ async function installDependencies({ try { await execa( pkgManager, - [ - "install", - ...(pkgManager === "deno" - ? ["--node-modules-dir=true", "--no-lock"] - : []), - ], + ["install", ...(pkgManager === "deno" ? ["--no-lock"] : [])], { cwd, env: pkgManager === "deno" ? { DENO_FUTURE: "1" } : undefined,