-
-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v6] HashRouter 'hashType' prop is no longer supported #7703
Comments
Router v6 is based on History v5, which removes |
This is a request to reconsider this issue. The old v5 API of
I've opened a PR (#8450) that allows UPDATE:This is now possible with |
@thejohnhoffer I'm using UPDATE: |
I'm happy you're using it @fnick851. Please let me know of any issues you're facing. For anyone else, here is a template you can use for now.. You can use |
is this workaround still required for [email protected]? |
@thejohnhoffer I'm looking to use use-hash-history but implementation isn't clear, are you able to assist? |
Version
6.0.0-beta.0
Test Case
Example working with Version 5.2: https://codesandbox.io/s/brave-bouman-xye62?file=/src/App.js
Example with 6.0 beta.0: https://codesandbox.io/s/friendly-wood-5tj4f?file=/src/App.js
Steps to reproduce
Using
<HashRouter/>
with thehashType="noslash"
prop does not work in v6, only the default slash behaviour is supported in v6.Expected Behavior
hashType prop would be supported just like in version 5.1 as described in https://github.com/ReactTraining/react-router/blob/master/packages/react-router-dom/docs/api/HashRouter.md#hashtype-string
There are no notices about hashType being deprecated anywhere.
Actual Behavior
always behaves as with
<HashRouter hashType="slash"/>
which was the default behaviour.The text was updated successfully, but these errors were encountered: