diff --git a/.github/workflows/integration-full.yml b/.github/workflows/integration-full.yml index ad23091b62..bdebc1d319 100644 --- a/.github/workflows/integration-full.yml +++ b/.github/workflows/integration-full.yml @@ -34,7 +34,7 @@ jobs: uses: ./.github/workflows/shared-integration.yml with: os: "ubuntu-latest" - node_version: '[18, "20.5.1"]' + node_version: "[18, 20]" browser: '["chromium", "firefox"]' integration-windows: @@ -43,7 +43,7 @@ jobs: uses: ./.github/workflows/shared-integration.yml with: os: "windows-latest" - node_version: '[18, "20.5.1"]' + node_version: "[18, 20]" browser: '["msedge"]' integration-macos: @@ -52,5 +52,5 @@ jobs: uses: ./.github/workflows/shared-integration.yml with: os: "macos-latest" - node_version: '[18, "20.5.1"]' + node_version: "[18, 20]" browser: '["webkit"]' diff --git a/.github/workflows/integration-pr-ubuntu.yml b/.github/workflows/integration-pr-ubuntu.yml index 7ee96ab4b6..6223906475 100644 --- a/.github/workflows/integration-pr-ubuntu.yml +++ b/.github/workflows/integration-pr-ubuntu.yml @@ -31,5 +31,5 @@ jobs: uses: ./.github/workflows/shared-integration.yml with: os: "ubuntu-latest" - node_version: '["20.5.1"]' + node_version: "[20]" browser: '["chromium"]' diff --git a/.github/workflows/integration-pr-windows-macos.yml b/.github/workflows/integration-pr-windows-macos.yml index d2bac08a5e..e8a84d92a3 100644 --- a/.github/workflows/integration-pr-windows-macos.yml +++ b/.github/workflows/integration-pr-windows-macos.yml @@ -19,7 +19,7 @@ jobs: uses: ./.github/workflows/shared-integration.yml with: os: "ubuntu-latest" - node_version: '["20.5.1"]' + node_version: "[20]" browser: '["firefox"]' integration-msedge: @@ -28,7 +28,7 @@ jobs: uses: ./.github/workflows/shared-integration.yml with: os: "windows-latest" - node_version: '["20.5.1"]' + node_version: "[20]" browser: '["msedge"]' integration-webkit: @@ -37,5 +37,5 @@ jobs: uses: ./.github/workflows/shared-integration.yml with: os: "macos-latest" - node_version: '["20.5.1"]' + node_version: "[20]" browser: '["webkit"]' diff --git a/.nvmrc b/.nvmrc index 6f7af3750c..2edeafb09d 100644 --- a/.nvmrc +++ b/.nvmrc @@ -1 +1 @@ -20.5.1 \ No newline at end of file +20 \ No newline at end of file diff --git a/integration/playwright.config.ts b/integration/playwright.config.ts index 8bdba0432e..dc5e4edaa5 100644 --- a/integration/playwright.config.ts +++ b/integration/playwright.config.ts @@ -6,6 +6,11 @@ const config: PlaywrightTestConfig = { testMatch: ["**/*-test.ts"], // TODO: Temporary! Remove from this list as we get each suite passing testIgnore: ["**/vite-cloudflare-test.ts"], + // Playwright treats our workspace packages as internal by default. If we + // don't mark them as external, tests hang in Node 20.5.2+ + build: { + external: ["**/packages/**/*"], + }, /* Maximum time one test can run for. */ timeout: process.platform === "win32" ? 60_000 : 30_000, fullyParallel: true,