Fix unit test errors due to new version of pydantic #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jguiditta
previously approved these changes
Jul 13, 2023
src/bugjira/config.py
Outdated
|
|
||
| class ConfigDict(BaseModel): | ||
| model_config = ConfigDict(extra='forbid') |
There was a problem hiding this comment.
This seems oddly recursive, I wonder if we should consider renaming this class (could be in a different patch) to make it less confusing?
There was a problem hiding this comment.
oops! good catch.
There was a problem hiding this comment.
I was wondering as well... and I think that's why we have to "import pydantic" instead of just having a specific class import on the next line, like for the other imports? After I asked the question, I realised it would conflict with our custom class, but would agree otherwise on maybe renaming for clarity in a later patch, if that is possible.
Pydantic updated to v2.x, so a bunch of pipeline unit tests started failing. This patch follows the migration recommendations from pydantic to get the tests passing again.
eggmaster
force-pushed
the
pydantic_upgrade_fixes
branch
from
4397372
to
fabf467
Compare
jguiditta
approved these changes
Jul 13, 2023
jpichon
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pydantic updated to v2.x, so a bunch of pipeline unit tests started failing. This patch follows the migration recommendations from pydantic to get the tests passing again.