Update to 1.24rc1. Updated benchmark tool usage. #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meling
requested changes
Jan 7, 2025
| @@ -1,6 +1,6 @@ | |||
| module github.com/relab/hotstuff | |||
|
|
|||
| go 1.23.4 | |||
| go 1.24rc1 | |||
There was a problem hiding this comment.
I forgot to mention that when updating to newer versions of Go, we must also update GitHub actions workflow files that refer to the version to test. I'm not sure the different actions work with release candidate versions, but we should try. But I am sure that golangci-lint will not work with newer versions of Go unless we compile our own golangci-lint binary, and that's a pain not worth doing in this PR.
There was a problem hiding this comment.
Tried it and it seems to not work. Maybe we need to wait for the full release?
There was a problem hiding this comment.
Yeah, let's not waste time on this.
|
Remember also to update the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #147
Runs locally without issues, test pass and benchmarks work as intended.