Moon phase integration not recognized after 2024.4 update #122

Nakiros · 2024-04-04T05:57:00Z

After 2024.4 update, "(!)" appeared next to moon phase. I reinstalled Moon integration, I reinstalled Horizon card, did HA restart several times, and the "(!)" still won't go away.

Maraptor · 2024-04-04T16:17:54Z

I have the same problem with moon phases after the update.

MDV85 · 2024-04-05T03:03:16Z

I have the same problem with moon phases after the update...

iva2019528 · 2024-04-06T16:38:24Z

I have the same problem with moon phases after the update.

pbranly · 2024-04-07T05:49:05Z

Hi same issue and Furthemore, it is in English while the moon phase sensor gives the information in my native French language

nepozs · 2024-04-07T20:33:20Z

The same issue, but problems with Moon are language independent - it is always English only and wrong phase with "(!)" for sure it is HA core 2024.4.x dependent.

Nakiros · 2024-04-08T10:31:25Z

Update: the moon phase updated to "new moon" as expected from "waning crescent", so i believe that it connects to the Moon integration, retrevies information from it, but form some unknown reason, it also writes the "(!)"

RaynePhantasm · 2024-04-08T16:00:06Z

Additional information: This message appears when you hover over "new_moon (!)":
"Install Moon integration to get localized Moon phase name" even though the integration is already installed.

doctorkb · 2024-04-08T23:54:19Z

connects to the Moon integration

No, it displayed that much before I installed the Moon integration. It's just the translation that needs the integration.

ThomDietrich · 2024-04-09T08:36:09Z

Hey all, thanks for all the reports.
Anyone amongst you brave enough to submit a fixing PR? :)

tigers75 · 2024-04-10T09:00:54Z

I don't know how to fix it, just to add that it does not work even if forcing the language with the option instead of relying on the card getting the HA language.

Embout · 2024-04-14T09:32:22Z

There is a typo in the code. Line 2740:

     var moon_phase_localized = i18n.localize("component.sensor.state.moon__phase.".concat(phase.state));

Double underscore in entity name

RogMoe · 2024-04-14T09:51:42Z

There is a typo in the code. Line 2740:
     var moon_phase_localized = i18n.localize("component.sensor.state.moon__phase.".concat(phase.state));
Double underscore in entity name

...but fixing that does not solve the issue...

rmd-gh · 2024-04-15T08:34:39Z

I took a look at the moon source strings.json and it appears that line 2740 needs to be

var moon_phase_localized = i18n.localize("component.moon.entity.sensor.phase.state.".concat(phase.state));

Making that change fixed it for me

RogMoe · 2024-04-15T08:55:40Z

rmd-gh · 2024-04-15T09:13:24Z

It could be that my "fix" is a fluke that only works for English (not a js guy and no idea how the localisation class works). Do make sure that you don't have a cached lovelace-horizon-card.js in your browser though. I had to clear the cache and reload that file.

rmd-gh · 2024-04-15T09:38:49Z

I should add that I had to edit the gz file. That seems to be the one that is served

mateuszdrab · 2024-04-15T10:10:06Z

@rmd-gh that worked for me too - even when I switched language to Polish

By the way, you can remove the gz file when editing, it's simply a compressed version to speed up loading but the script loads just fine without it.

Perhaps PR it?

RogMoe · 2024-04-15T11:08:06Z

It could be that my "fix" is a fluke that only works for English (not a js guy and no idea how the localisation class works). Do make sure that you don't have a cached lovelace-horizon-card.js in your browser though. I had to clear the cache and reload that file.

Cache cleared and reloaded the page. Not working for me (in Dutch).

JokeRsevilla · 2024-04-15T16:49:23Z

var moon_phase_localized = i18n.localize("component.moon.entity.sensor.phase.state.".concat(phase.state));

works for me in Spanish, just by reloading the page, modifying .js and removing .gz

JokeRsevilla · 2024-04-15T16:49:57Z

I took a look at the moon source strings.json and it appears that line 2740 needs to be

var moon_phase_localized = i18n.localize("component.moon.entity.sensor.phase.state.".concat(phase.state));

Making that change fixed it for me

thank you so much!

RogMoe · 2024-04-15T18:20:57Z

Fixed it too! Thx @rmd-gh !

ThomDietrich · 2024-04-15T19:47:31Z

Whoever publishes the PR gets mentioned in the release notes! :)

rmd-gh · 2024-04-15T21:07:49Z

If anyone wants to do a PR, feel free. I don't know enough about building typescript to test, or using github to do that. The actual source location appears to be lovelace-horizon-card/src/utils/HelperFunctions.ts:32

maatx · 2024-04-16T09:30:55Z

I took a look at the moon source strings.json and it appears that line 2740 needs to be

var moon_phase_localized = i18n.localize("component.moon.entity.sensor.phase.state.".concat(phase.state));

Making that change fixed it for me

Thanks so much, it also worked for the Italian version !

JokeRsevilla · 2024-04-16T10:58:52Z

@nepozs has already created a pull request

#127 👍

jm314159 · 2024-04-16T21:44:37Z

I took a look at the moon source strings.json and it appears that line 2740 needs to be
var moon_phase_localized = i18n.localize("component.moon.entity.sensor.phase.state.".concat(phase.state));
Making that change fixed it for me

Thanks so much, it also worked for the Italian version !

My settings are PL in general apart from language which is EN. The solution is working fine. I only had to convince ;) my browser to refresh the settings effectively. A restart of the core was insufficient. Neither was a common F5 or CTRL+F5. Cleaning the browser cache of past two hours was what only helped.

It is just worth noting I think, in another browser that I did not use to use for HA, just after I logged in, there was no exclamation mark at all.

Bilo2110 · 2024-04-17T18:59:15Z

I took a look at the moon source strings.json and it appears that line 2740 needs to be
var moon_phase_localized = i18n.localize("component.moon.entity.sensor.phase.state.".concat(phase.state));
Making that change fixed it for me

Thanks so much, it also worked for the Italian version !

I've try to do this fix, but for me not working in Italian language

Bilo2110 · 2024-04-17T20:05:08Z

I took a look at the moon source strings.json and it appears that line 2740 needs to be
var moon_phase_localized = i18n.localize("component.moon.entity.sensor.phase.state.".concat(phase.state));
Making that change fixed it for me

Thanks so much, it also worked for the Italian version !

Can you help me @maatx for italian language?

nepozs · 2024-04-17T20:08:27Z

Can you help me @maatx for italian language?

This issue is language independent, clear cache in browser.

Bilo2110 · 2024-04-17T20:10:13Z

I've try to crear cache of browser and the app Homeassistant, but not working

…

________________________________ From: nepozs ***@***.***> Sent: Wednesday, April 17, 2024 10:08:53 PM To: rejuvenate/lovelace-horizon-card ***@***.***> Cc: Bilo2110 ***@***.***>; Comment ***@***.***> Subject: Re: [rejuvenate/lovelace-horizon-card] Moon phase integration not recognized after 2024.4 update (Issue #122) Can you help me @maatx<https://github.com/maatx> for italian language? This issue is language independent, clear cache in browser. — Reply to this email directly, view it on GitHub<#122 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BA6FD6KFCSLX4KJNKKWBQ33Y53JFLAVCNFSM6AAAAABFWS5YFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGEZTGMJVHA>. You are receiving this because you commented.Message ID: ***@***.***>

jm314159 · 2024-04-17T20:12:27Z

Have you tried in secure/private mode? Or on another computer/laptop/phone?

nepozs · 2024-04-17T20:12:51Z

Maybe italian translation is incomplete? Does Moon integration work OK?

Bilo2110 · 2024-04-17T20:29:01Z

Have you tried in secure/private mode? Or on another computer/laptop/phone?

I've try whit private mode in Chrome by smartphone, but same problem

Bilo2110 · 2024-04-17T20:30:40Z

Maybe italian translation is incomplete? Does Moon integration work OK?

Moon integration work, and give me correct italian translation. Not work in this card.
I've tried to add new card... Same problem

jm314159 · 2024-04-17T20:50:47Z

Perhaps, if not yet attempted, you could try with changing the language for a while with
language: en
or setting the least config

type: custom:horizon-card
fields:
  moon_phase: true

followed each time by restarting the Core and browser cache/history cleaning (or private mode).

Bilo2110 · 2024-04-17T20:54:02Z

Wait wait wait... After deleting the .gz file, edit line 2740, cleared cache, finally WORK!!! Thx for all

…

________________________________ From: jm314159 ***@***.***> Sent: Wednesday, April 17, 2024 10:51:12 PM To: rejuvenate/lovelace-horizon-card ***@***.***> Cc: Bilo2110 ***@***.***>; Comment ***@***.***> Subject: Re: [rejuvenate/lovelace-horizon-card] Moon phase integration not recognized after 2024.4 update (Issue #122) Perhaps, if not yet attempted, you could try with changing the language for a while with language: en or setting the least config type: custom:horizon-card fields: moon_phase: true followed each time by restarting the Core and browser cache/history cleaning (or private mode). — Reply to this email directly, view it on GitHub<#122 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BA6FD6MGTN3WAJFO4HHGGXDY53OEBAVCNFSM6AAAAABFWS5YFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGI4DEMRRGU>. You are receiving this because you commented.Message ID: ***@***.***>

jm314159 · 2024-04-17T21:07:35Z

Well, indeed, I forgot that step in my first message. I have also recreated .gz
gzip lovelace-horizon-card.js -k

Congrats to you! :)

ThomDietrich · 2024-04-23T16:58:02Z

Hello everyone, sadly I didn't have the time to merge this one yet (or rather other PRs I want to publish alongside this fix).
Will take care of it this evening!

ThomDietrich · 2024-04-23T21:20:24Z

Hey all,
I did merge the PR but sadly our build release pipeline isn't happy with it. Could you @nepozs or someone else please look into this? I am not a js/ts developer.

https://github.com/rejuvenate/lovelace-horizon-card/actions/runs/8807266271

nepozs · 2024-04-24T00:46:18Z

Nor I am… sorry, looks it needs more changes…

Bilo2110 · 2024-04-24T03:42:18Z

Hacs give me update from v1.0.0 to v1.0.0.. is possible?

…

________________________________ From: nepozs ***@***.***> Sent: Wednesday, April 24, 2024 2:46:45 AM To: rejuvenate/lovelace-horizon-card ***@***.***> Cc: Bilo2110 ***@***.***>; Comment ***@***.***> Subject: Re: [rejuvenate/lovelace-horizon-card] Moon phase integration not recognized after 2024.4 update (Issue #122) Nor I am… sorry, looks it needs more changes… — Reply to this email directly, view it on GitHub<#122 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/BA6FD6JMWDG2MUNCTKSES73Y636HLAVCNFSM6AAAAABFWS5YFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANZTG4ZTSMJWGU>. You are receiving this because you commented.Message ID: ***@***.***>

tormentor22 · 2024-04-25T18:49:09Z

Wait wait wait... After deleting the .gz file, edit line 2740, cleared cache, finally WORK!!! Thx for all
…
________________________________ From: jm314159 @.> Sent: Wednesday, April 17, 2024 10:51:12 PM To: rejuvenate/lovelace-horizon-card @.> Cc: Bilo2110 @.>; Comment @.> Subject: Re: [rejuvenate/lovelace-horizon-card] Moon phase integration not recognized after 2024.4 update (Issue #122) Perhaps, if not yet attempted, you could try with changing the language for a while with language: en or setting the least config type: custom:horizon-card fields: moon_phase: true followed each time by restarting the Core and browser cache/history cleaning (or private mode). — Reply to this email directly, view it on GitHub<#122 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/BA6FD6MGTN3WAJFO4HHGGXDY53OEBAVCNFSM6AAAAABFWS5YFOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANRSGI4DEMRRGU. You are receiving this because you commented.Message ID: @.***>

Same in German. After editing line 2740 and delete *.gz it work now. Thank you guys

ThomDietrich · 2024-04-26T08:39:36Z

@avataar @edwardtfn are you guys around to have a look at this?

MelleD · 2024-04-26T22:48:43Z

For me the fix do not work.

I need this as entity: component.moon.entity.sensor.phase.state. Then everything is working. The fix without "moon" is not working. I saw also some test issue with the persia language tests. I ignore them for the first time. Maybe someone who speak the lang should add tests for that :-).

I had some trouble with the build pipeline.
My changes were not taken into the release.

#131

s-hutter · 2024-05-04T13:27:12Z

Quick fix using Card Mod without modifying files (English only):

type: custom:horizon-card
time_format: 24
fields:
  moonrise: true
  moon_phase: true
  moonset: true
card_mod:
  style: |
    .horizon-card-field-value-moon-phase span {display: none;}
    .horizon-card-field-value-moon-phase:before {content: "{{states('sensor.moon_phase')|replace('_',' ')|title}}";}

DJaeger · 2024-05-05T15:04:19Z

Quick fix with modifying file (incl. localized) from terminal/ssh:

cd config/www/community/lovelace-horizon-card/
sed -i 's/component.sensor.state.moon__phase./component.moon.entity.sensor.phase.state./g' lovelace-horizon-card.js
rm -f lovelace-horizon-card.js.gz &&  gzip lovelace-horizon-card.js -k
ha core restart

Clear your browser cache and reload afterwards!

MelleD · 2024-05-06T07:25:49Z

I already fixed it, PR is still open.

Meanwhile you could try it with my repo. It's released here:
https://github.com/MelleD/lovelace-horizon-card

dunxd · 2024-05-06T15:23:20Z

Looking forward to the PR that fixes this being merged.

ThomDietrich · 2024-05-21T09:23:38Z

Dear all,
this bug is now fixed in the most recent release https://github.com/rejuvenate/lovelace-horizon-card/releases/tag/v1.1.0 - there are a lot more changes in that release.

This repository is hosted under the rejuvenate organization. We are always open to new contributions and happy for anyone participating in discussions and the review process! If you are a passionate js/ts developer and would like to be more involved with this project please also check the open feature suggestions ;)

Cheers!

ThomDietrich mentioned this issue Apr 11, 2024

no translation into Italian of the moon phases but the English name remains followed by (!) #125

Closed

ThomDietrich mentioned this issue Apr 16, 2024

Update HelperFunctions.ts #127

Merged

11 tasks

ThomDietrich mentioned this issue Apr 23, 2024

Started showing code instead of state on moon #129

Closed

ThomDietrich closed this as completed in #127 Apr 23, 2024

jm314159 mentioned this issue Apr 25, 2024

No connection to moon-integration #130

Closed

ThomDietrich reopened this Apr 26, 2024

MelleD mentioned this issue Apr 26, 2024

Fix moon phase integration #131

Open

6 tasks

tripplehelix mentioned this issue Apr 27, 2024

Text for moon phase #133

Closed

trvrnrth mentioned this issue May 18, 2024

Fix moon phase translation key #134

Merged

10 tasks

ThomDietrich closed this as completed in #134 May 21, 2024

Moon phase integration not recognized after 2024.4 update #122

Moon phase integration not recognized after 2024.4 update #122

Comments

Nakiros commented Apr 4, 2024 • edited Loading

Maraptor commented Apr 4, 2024

MDV85 commented Apr 5, 2024 • edited Loading

iva2019528 commented Apr 6, 2024

pbranly commented Apr 7, 2024

nepozs commented Apr 7, 2024

Nakiros commented Apr 8, 2024 • edited Loading

RaynePhantasm commented Apr 8, 2024 • edited Loading

doctorkb commented Apr 8, 2024

ThomDietrich commented Apr 9, 2024

tigers75 commented Apr 10, 2024

Embout commented Apr 14, 2024

RogMoe commented Apr 14, 2024

rmd-gh commented Apr 15, 2024

RogMoe commented Apr 15, 2024

rmd-gh commented Apr 15, 2024

rmd-gh commented Apr 15, 2024

mateuszdrab commented Apr 15, 2024 • edited Loading

RogMoe commented Apr 15, 2024

JokeRsevilla commented Apr 15, 2024

JokeRsevilla commented Apr 15, 2024

RogMoe commented Apr 15, 2024

ThomDietrich commented Apr 15, 2024

rmd-gh commented Apr 15, 2024

maatx commented Apr 16, 2024

JokeRsevilla commented Apr 16, 2024

jm314159 commented Apr 16, 2024

Bilo2110 commented Apr 17, 2024

Bilo2110 commented Apr 17, 2024

nepozs commented Apr 17, 2024

Bilo2110 commented Apr 17, 2024 via email

jm314159 commented Apr 17, 2024

nepozs commented Apr 17, 2024

Bilo2110 commented Apr 17, 2024

Bilo2110 commented Apr 17, 2024

jm314159 commented Apr 17, 2024

Bilo2110 commented Apr 17, 2024 via email

jm314159 commented Apr 17, 2024 • edited Loading

ThomDietrich commented Apr 23, 2024

ThomDietrich commented Apr 23, 2024

nepozs commented Apr 24, 2024

Bilo2110 commented Apr 24, 2024 via email

tormentor22 commented Apr 25, 2024 • edited Loading

ThomDietrich commented Apr 26, 2024

MelleD commented Apr 26, 2024 • edited Loading

s-hutter commented May 4, 2024

DJaeger commented May 5, 2024 • edited Loading

MelleD commented May 6, 2024 • edited Loading

dunxd commented May 6, 2024

ThomDietrich commented May 21, 2024

Nakiros commented Apr 4, 2024 •

edited

Loading

MDV85 commented Apr 5, 2024 •

edited

Loading

Nakiros commented Apr 8, 2024 •

edited

Loading

RaynePhantasm commented Apr 8, 2024 •

edited

Loading

mateuszdrab commented Apr 15, 2024 •

edited

Loading

jm314159 commented Apr 17, 2024 •

edited

Loading

tormentor22 commented Apr 25, 2024 •

edited

Loading

MelleD commented Apr 26, 2024 •

edited

Loading

DJaeger commented May 5, 2024 •

edited

Loading

MelleD commented May 6, 2024 •

edited

Loading