Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does it need to be passive? #9

Open
pauldijou opened this issue Sep 30, 2019 · 0 comments
Open

Does it need to be passive? #9

pauldijou opened this issue Sep 30, 2019 · 0 comments

Comments

@pauldijou
Copy link

I was reading the hook source code and I was wondering if it really needs to specify {passive: true}. The scroll event should be passive by default since it cannot be cancelled. Check the last paragraph:

You don't need to worry about the value of passive for the basic scroll event. Since it can't be canceled, event listeners can't block page rendering anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant