Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign logic of parser->has_syntax_error #7

Open
LefterisJP opened this issue Feb 5, 2017 · 0 comments
Open

Redesign logic of parser->has_syntax_error #7

LefterisJP opened this issue Feb 5, 2017 · 0 comments
Labels
stage:parser

Comments

@LefterisJP
Copy link
Contributor

The parser currently has this variable has_syntax_error and there are functions like parser_has_syntax_error() that use it.

Try to remove this logic and instead use the newly introduced info_ctx rollback along with a smart detection of if there was an error or not between a push and a pop.

There is a TODO for this here
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage:parser
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@LefterisJP