Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine signedness of comparisons in the RIR #32

Open
LefterisJP opened this issue Feb 15, 2017 · 1 comment
Open

Determine signedness of comparisons in the RIR #32

LefterisJP opened this issue Feb 15, 2017 · 1 comment

Comments

@LefterisJP
Copy link
Contributor

At the moment we simply ignore signedness of the compared integers and just always do signed comparisons.

This is an issue to track the implementation of:

Check the signedness of the integers of a comparison during RIR stage and:

  • if any of the two integers is signed then do signed comparison
  • if both are unsigned then do unsigned comparison
@orbit-stabilizer
Copy link
Contributor

Hi, I cannot seem to find any of the header files for rir.

It seems like you would like to take the bllvm_compile_comparison function out of the llvm_operators module and place the functionality inside one of the rir modules. Or do you just want to add additional types to rir_expression?

Apologies if this doesn't seem even remotely correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants