Skip to content

Commit 130179a

Browse files
authored
Merge branch 'master' into bugfix/nodelist-abbrev-multiple-10
2 parents 06ed99f + 925be11 commit 130179a

File tree

4 files changed

+12
-11
lines changed

4 files changed

+12
-11
lines changed

docs/manpage.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1043,7 +1043,7 @@ The way the tests are generated and how they interact with the test filtering op
10431043

10441044
Parameterize a test on an existing variable.
10451045

1046-
This option will create a new test with a parameter named ``$VAR`` with the values given in the comma-separated list ``VAL0,VAL1,...``.
1046+
The test will behave as if the variable ``VAR`` was a parameter taking the values ``VAL0,VAL1,...``.
10471047
The values will be converted based on the type of the target variable ``VAR``.
10481048
The ``TEST.`` prefix will only parameterize the variable ``VAR`` of test ``TEST``.
10491049

reframe/frontend/cli.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1041,7 +1041,8 @@ def restrict_logging():
10411041
with exit_gracefully_on_error('failed to retrieve test case data',
10421042
printer):
10431043
printer.info(jsonext.dumps(reporting.testcase_info(
1044-
options.describe_stored_testcases, namepatt
1044+
options.describe_stored_testcases,
1045+
namepatt, options.filter_expr
10451046
), indent=2))
10461047
sys.exit(0)
10471048

reframe/frontend/testgenerators.py

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -77,12 +77,12 @@ def _generate_tests(testcases, gen_fn):
7777
@time_function
7878
def distribute_tests(testcases, node_map):
7979
def _rfm_pin_run_nodes(obj):
80-
nodelist = getattr(obj, '$nid')
80+
nodelist = getattr(obj, '.nid')
8181
if not obj.local:
8282
obj.job.pin_nodes = nodelist
8383

8484
def _rfm_pin_build_nodes(obj):
85-
pin_nodes = getattr(obj, '$nid')
85+
pin_nodes = getattr(obj, '.nid')
8686
if obj.build_job and not obj.local and not obj.build_locally:
8787
obj.build_job.pin_nodes = pin_nodes
8888

@@ -99,9 +99,9 @@ def _rfm_set_valid_systems(obj):
9999
'valid_systems': [partition.fullname],
100100
# We add a partition parameter so as to differentiate the test
101101
# in case another test has the same nodes in another partition
102-
'$part': builtins.parameter([partition.fullname],
102+
'.part': builtins.parameter([partition.fullname],
103103
loggable=False),
104-
'$nid': builtins.parameter(
104+
'.nid': builtins.parameter(
105105
[[n] for n in node_map[partition.fullname]],
106106
fmt=util.nodelist_abbrev, loggable=False
107107
)
@@ -113,7 +113,7 @@ def _rfm_set_valid_systems(obj):
113113
# will not be overwritten by a parent post-init hook
114114
builtins.run_after('init')(_rfm_set_valid_systems),
115115
]
116-
), ['$part', '$nid']
116+
), ['.part', '.nid']
117117

118118
return _generate_tests(testcases, _make_dist_test)
119119

@@ -127,10 +127,10 @@ def _make_repeat_test(testcase):
127127
return make_test(
128128
cls.__name__, (cls,),
129129
{
130-
'$repeat_no': builtins.parameter(range(num_repeats),
130+
'.repeat_no': builtins.parameter(range(num_repeats),
131131
loggable=False)
132132
}
133-
), ['$repeat_no']
133+
), ['.repeat_no']
134134

135135
return _generate_tests(testcases, _make_repeat_test)
136136

@@ -164,7 +164,7 @@ def _make_parameterized_test(testcase):
164164
)
165165
continue
166166

167-
body[f'${var}'] = builtins.parameter(values, loggable=False)
167+
body[f'.{var}'] = builtins.parameter(values, loggable=False)
168168

169169
def _set_vars(self):
170170
for var in body.keys():

unittests/test_testgenerators.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ def sys0p0_nodes():
5151

5252
nodelist_iter = sys0p0_nodes()
5353
for tc in new_cases:
54-
nodes = getattr(tc.check, '$nid')
54+
nodes = getattr(tc.check, '.nid')
5555
if tc.partition.fullname == 'sys0:p0':
5656
assert nodes == next(nodelist_iter)
5757
else:

0 commit comments

Comments
 (0)