Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename array contains to includes #128

Open
kylef opened this issue Jul 7, 2017 · 1 comment
Open

Rename array contains to includes #128

kylef opened this issue Jul 7, 2017 · 1 comment
Milestone
1.0.0

Comments

@kylef
Copy link
Member

kylef commented Jul 7, 2017

In JavaScript array there is an includes method, it catches me out that the same functionality has a different method name in minim. I think we should align the name.

https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/includes
@kylef kylef added this to the 1.0.0 milestone Jul 7, 2017
@pksunkara
Copy link
Contributor

👍 . Go ahead with the PR.

kylef added a commit that referenced this issue Jun 12, 2020
@kylef
refactor: rename contains to includes (#128)
5646468
kylef added a commit that referenced this issue Jun 12, 2020
@kylef
refactor: rename contains to includes (#128)
732f092
kylef added a commit that referenced this issue Jun 12, 2020
@kylef
refactor: rename contains to includes (#128)
0febeb8
kylef added a commit that referenced this issue Jun 12, 2020
@kylef
refactor: rename contains to includes (#128)
f74a00d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0.0
Development

No branches or pull requests
2 participants
@kylef @pksunkara