Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reflex.Time.delay does not retain ordering #185

Closed
lspitzner opened this issue Apr 7, 2018 · 2 comments
Closed

Reflex.Time.delay does not retain ordering #185

lspitzner opened this issue Apr 7, 2018 · 2 comments

Comments

@lspitzner
Copy link
Contributor

The current implementation of delay does not ensure that order of events is preserved through delay, due to race-condition when the delayed events fire (which thread gets the lock first).

I don't think this necessarily needs to be fixed, as fixing it seems to make the implementation much more complex. But it should at least be pointed out in the haddocks and the quickref.

@lspitzner
Copy link
Contributor Author

Combining gateThrottle from #184 and the current delay gives you a fixed delay, I think.

@dfordivam
Copy link
Member

I think there is no action item here, as the behavior is not a bug. So closing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants