You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This, however, is too coarse-grained. We should instead first combine all the packages as work-ont-multi does. In the cross case we should also make two ghcWithPackages calls, one for Setup.hs with setup depends and buildHaskellPackages.ghcWithPackages in addition to the regular one. In the native case, we should combine regular haskell dependencies with setup-depends for one big ghcWithPackages call.
The text was updated successfully, but these errors were encountered:
Ericson2314
changed the title
Upstream work-on-multi into Nuxpkgs's shellFor
Upstream work-on-multi into Nixpkgs's shellForDec 20, 2019
I think the plan should be to somewhat undo NixOS/nixpkgs@51267d3 from that PR, in that .env will not use shellFor. Instead, shellFor would use .env: The logic from shellFor that is moved back inside generic-builder to define the .env, and the remaining bits of shellFor are replaced with work-on-multi, combining the packages into one package from which to get and use a .env.
See definition of
shellFor
in https://github.com/NixOS/nixpkgs/blob/8e4c9d15456fd3a35044bcea864d558fade4a021/pkgs/development/haskell-modules/make-package-set.nix#L253-L323 . It works today by splitting the dependencies as "haskell" vs "system", and then making a shell based off of this.This, however, is too coarse-grained. We should instead first combine all the packages as work-ont-multi does. In the cross case we should also make two
ghcWithPackages
calls, one forSetup.hs
with setup depends andbuildHaskellPackages.ghcWithPackages
in addition to the regular one. In the native case, we should combine regular haskell dependencies withsetup-depends
for one bigghcWithPackages
call.The text was updated successfully, but these errors were encountered: