unknown attribute 'images_attributes' for Refinery::Page if only added to extension

[javinto]

I had a RefineryCMS 2.x installation with a Projects extension where I had added the PageImages extension to the projects only:

config.enable_for = [
    {model: "Refinery::Projects::Project", tab: "Refinery::Projects::Tab"}
]

On upgrading to RefineryCMS 3.x I now get an exception error on updating a RefineryPage: unknown attribute 'images_attributes' for Refinery::Page

When I add {model: "Refinery::Page", tab: "Refinery::Pages::Tab"} to the above config the exception disappears but then I have a Images tab on every Page which I do not want.

The problem seems to be that in the pages_controller_decorator.rb the permitted_page_params are added unconditionally.

It is not a show stopper, but could it be solved?

[bricesanchez]

Hi @javinto it looks like enable_for does not do its job like it should. we probably should add conditional statement in the pages_controller_decorator.rb

[javinto]

Hi Brian, I certainly would like to contribute to RefineryCMS but am not able to do that at short notice. I will plan to have a look at this issue in about 4 weeks time. I hope that is okay.

…

Op 26 jan. 2018, om 14:10 heeft Brice Sanchez ***@***.***> het volgende geschreven: Hi @javinto <https://github.com/javinto> it looks like enable_for does not do its job like it should. we probably should add conditional statement in the pages_controller_decorator.rb — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#140 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAWNN4CbajASbXLJKYb2MT_riZ6kYTWQks5tOc68gaJpZM4LS5Az>.