Skip to content

Commit b506ac1

Browse files
Finally fixed 2D popup off-center issue
Finally fixed 2D popup off-center issue. A div that I thought was dangling, well, wasn't...
1 parent bb077e3 commit b506ac1

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

report/src/main/java/org/hjug/refactorfirst/report/HtmlReport.java

+6-6
Original file line numberDiff line numberDiff line change
@@ -500,11 +500,12 @@ public String renderClassGraphDotImage() {
500500

501501
StringBuilder stringBuilder = new StringBuilder();
502502
stringBuilder.append("<h1 align=\"center\">Class Map</h1>");
503-
stringBuilder.append("<div align=\"center\">Excludes classes that have no incoming and outgoing edges<br>");
503+
stringBuilder.append(
504+
"<div align=\"center\">Excludes classes that have no incoming and outgoing edges<br></div>");
504505
stringBuilder.append("<script>\n");
505506
stringBuilder.append("const " + classGraphName + "_dot = " + dot + "\n");
506507
stringBuilder.append("</script>\n");
507-
stringBuilder.append(generateForce3DPopup(classGraphName + "3D"));
508+
stringBuilder.append(generateForce3DPopup(classGraphName));
508509

509510
stringBuilder.append(generate2DPopup(classGraphName));
510511

@@ -588,7 +589,8 @@ public String renderCycleDotImage(RankedCycle cycle) {
588589
stringBuilder.append("<script>\n");
589590
stringBuilder.append("const " + cycleName + "_dot = " + dot + "\n");
590591
stringBuilder.append("</script>\n");
591-
stringBuilder.append(generateForce3DPopup(cycleName + "3D"));
592+
stringBuilder.append(generateForce3DPopup(cycleName));
593+
stringBuilder.append(generate2DPopup(cycleName));
592594

593595
stringBuilder.append("<div align=\"center\">\n");
594596
stringBuilder.append("Red lines represent back edges to remove.<br>\n");
@@ -609,7 +611,6 @@ public String renderCycleDotImage(RankedCycle cycle) {
609611
} else {
610612
// revisit and add D3 popup button as well
611613

612-
stringBuilder.append(generate2DPopup(cycleName));
613614
}
614615

615616
stringBuilder.append("<br/>\n");
@@ -681,9 +682,8 @@ String generate2DPopup(String cycleName) {
681682

682683
String generateForce3DPopup(String cycleName) {
683684
// Created by generative AI and modified
684-
String correctName = cycleName.replace("3D", "");
685685
return "<button style=\"display: block; margin: 0 auto;\" onclick=\"createForceGraph('popup-" + cycleName
686-
+ "', 'graph-container-" + cycleName + "'," + correctName + "_dot )\">Show " + correctName
686+
+ "', 'graph-container-" + cycleName + "'," + cycleName + "_dot )\">Show " + cycleName
687687
+ " 3D Popup</button>\n" + "\n"
688688
+ "<div class=\"popup\" id=\"popup-"
689689
+ cycleName + "\">\n" + " <span class=\"close-btn\" onclick=\"hidePopup()\">×</span>\n"

0 commit comments

Comments
 (0)