Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile is not included in context hash if ignored #118

Open
ethanwu10 opened this issue Feb 14, 2021 · 0 comments
Open

Dockerfile is not included in context hash if ignored #118

ethanwu10 opened this issue Feb 14, 2021 · 0 comments
Labels
component/core kind/bug Something isn't working

Comments

@ethanwu10
Copy link
Member

If a Dockerfile is excluded by .dockerignore rules, it is removed from the files to hash to compute the image tag. However, the Dockerfile passed to Docker is always included, regardless of ignore rules, so we should ensure that whichever Dockerfile is used to build a container is always included in the hash (by explicitly adding it to the list).

@ethanwu10 ethanwu10 added kind/bug Something isn't working component/core labels Feb 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/core kind/bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant